Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NSHMP mag-dependent rupture floating #2

Closed
pmpowers-usgs opened this issue May 30, 2014 · 3 comments · Fixed by #86
Closed

Implement NSHMP mag-dependent rupture floating #2

pmpowers-usgs opened this issue May 30, 2014 · 3 comments · Fixed by #86

Comments

@pmpowers-usgs
Copy link
Member

No description provided.

@pmpowers-usgs
Copy link
Member Author

This needs to be implemented to more closely match fortran codes.

@pmpowers-usgs pmpowers-usgs removed their assignment Jul 31, 2014
@pmpowers-usgs pmpowers-usgs added this to the Verification milestone Feb 11, 2016
@pmpowers-usgs
Copy link
Member Author

This should also add some tests for building GriddedSurfaces.

@pmpowers-usgs
Copy link
Member Author

NHSMP Rupture floating was implemented some time ago when the RuptureFloating enum was implemented. Initial experimentation suggests it works properly, but we are going to let verification with NSHMP fortran codes proceed before changing gridded surface floating implementations or writing tests.

In starting work on writing tests for rupture floating, inadequacies in the geo and surface packages came to light. Extensive work has been done to refactor and write tests for Location and LocationList, which is now complete. This and any associated refactoring will be merged as part of closing out this issue. Future work on the Location to GriddedSurface hierarchy will be conducted under issue #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant