-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4119 - Fix skipped links in toolbar area of map page #1606
Merged
AmTryingMyBest
merged 7 commits into
ushahidi:develop
from
Ifycode:4119-button-focus-tabkey
Nov 26, 2020
Merged
#4119 - Fix skipped links in toolbar area of map page #1606
AmTryingMyBest
merged 7 commits into
ushahidi:develop
from
Ifycode:4119-button-focus-tabkey
Nov 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifycode
changed the title
Change sort & filter and share links inside toolbar to button
#4119 - Change sort & filter and share links inside toolbar to button
Oct 28, 2020
6 tasks
Ifycode
changed the title
#4119 - Change sort & filter and share links inside toolbar to button
#4119 - Fix skipped links in toolbar in toolbar area of map page
Oct 28, 2020
@Ifycode Is this ready for review? |
Yes @Angamanga This is ready for review. |
This was referenced Oct 31, 2020
Merged
Ifycode
changed the title
#4119 - Fix skipped links in toolbar in toolbar area of map page
#4119 - Fix skipped links in toolbar area of map page
Oct 31, 2020
Angamanga
previously approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🎉 Approved!
Yay! Thanks @Angamanga |
@Obadha2 Ready for QA. Styling-changes are in this pr: #1627 |
8 tasks
Angamanga
approved these changes
Nov 26, 2020
QA'd, passes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Issues, observation & steps taken:
Associated platform pattern library PRs:
Platform pattern library PR 1.
Platform pattern library PR 2.
Testing checklist:
Add assets folder from platform-pattern-library containing the new changes made to the platform-client which also contains some new changes and run the project.
Login, and use tab key to navigate the toolbar on the map page.
Check that buttons are not skipped.
Check that it is clear to user that a button is in focus.
I certify that I ran my checklist
Fixes ushahidi/platform#4119 .
Ping @ushahidi/platform