Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4119 - Fix skipped links in toolbar area of map page #1606

Merged
merged 7 commits into from
Nov 26, 2020
Merged

#4119 - Fix skipped links in toolbar area of map page #1606

merged 7 commits into from
Nov 26, 2020

Conversation

Ifycode
Copy link
Member

@Ifycode Ifycode commented Oct 28, 2020

This pull request makes the following changes:

Issues, observation & steps taken:

  • Sort & filter and share links are skipped when navigating with the tab key, as they were links that had no href.
  • In smaller devices, span.mode-context-trigger is skipped.
  • Converted them both to button so that the focus set for buttons in the pattern library will work on them.

Associated platform pattern library PRs:

Testing checklist:

  • Add assets folder from platform-pattern-library containing the new changes made to the platform-client which also contains some new changes and run the project.

  • Login, and use tab key to navigate the toolbar on the map page.

  • Check that buttons are not skipped.

  • Check that it is clear to user that a button is in focus.

  • I certify that I ran my checklist

Fixes ushahidi/platform#4119 .

Ping @ushahidi/platform

@ushbot
Copy link
Collaborator

ushbot commented Oct 28, 2020

Hey @Ifycode,
thank you for your Pull Request.

@rjmackay It looks like this brave person signed our Contributor License Agreement. 👍

Always at your service,

clabot

@Ifycode Ifycode changed the title Change sort & filter and share links inside toolbar to button #4119 - Change sort & filter and share links inside toolbar to button Oct 28, 2020
@Ifycode Ifycode changed the title #4119 - Change sort & filter and share links inside toolbar to button #4119 - Fix skipped links in toolbar in toolbar area of map page Oct 28, 2020
@Angamanga
Copy link
Collaborator

@Ifycode Is this ready for review?

@Ifycode
Copy link
Member Author

Ifycode commented Oct 31, 2020

Yes @Angamanga This is ready for review.

@Ifycode Ifycode changed the title #4119 - Fix skipped links in toolbar in toolbar area of map page #4119 - Fix skipped links in toolbar area of map page Oct 31, 2020
Angamanga
Angamanga previously approved these changes Nov 20, 2020
Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🎉 Approved!

@Ifycode
Copy link
Member Author

Ifycode commented Nov 20, 2020

Yay! Thanks @Angamanga

@Angamanga Angamanga mentioned this pull request Nov 20, 2020
1 task
@Angamanga
Copy link
Collaborator

@Obadha2 Ready for QA. Styling-changes are in this pr: #1627

@AmTryingMyBest AmTryingMyBest merged commit 5768c4d into ushahidi:develop Nov 26, 2020
@AmTryingMyBest
Copy link
Contributor

QA'd, passes. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants