Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4119 - Improve focus for checkboxes, radio and input fields #258

Merged
merged 1 commit into from
Nov 20, 2020
Merged

#4119 - Improve focus for checkboxes, radio and input fields #258

merged 1 commit into from
Nov 20, 2020

Conversation

Ifycode
Copy link
Member

@Ifycode Ifycode commented Oct 31, 2020

This pull request makes the following changes:

Issue, observation & steps taken:

  • It is not so obvious to the eyes when focus is on a particular checkbox, radio and input fields in general. Added outlineand increased the blur and spread of the box-shadow to give it an elevated look and make it catch the attention of user easily. See associated platform-client PR.

Testing checklist:

  • Add assets folder from platform-pattern-library containing the new changes made to the platform-client which also contains some new changes and run the project.

  • Login, navigate the search filter & the map page) using the tab key.

  • Check that the checkboxes, radio buttons and input fields in general are more noticable on focus (general problem all over the site).

  • I certify that I ran my checklist

Fixes ushahidi/platform#4119 .

Ping @ushahidi/platform

@Ifycode Ifycode changed the title 4119 - Improve focus for checkboxes, radio and input fields #4119 - Improve focus for checkboxes, radio and input fields Oct 31, 2020
@Ifycode
Copy link
Member Author

Ifycode commented Oct 31, 2020

Hi @Angamanga please discard that other PR i started with.

This is the 1st new PR that deals with input fields (only).
Please help review.

@Angamanga Angamanga changed the base branch from master to v4.4.4 November 20, 2020 11:08
@Angamanga Angamanga merged commit 3247964 into ushahidi:v4.4.4 Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weak color contrast and issues for tab key users in the map and search area of the map page.
2 participants