Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add translations to minimal surveys format #4026

Merged
merged 1 commit into from Jul 22, 2020

Conversation

leninpaulino
Copy link
Contributor

@leninpaulino leninpaulino commented Jul 22, 2020

This pull request makes the following changes:

  • add translations to minimal surveys format

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes #4276 .

Ping @ushahidi/platform

Aha! Link: https://ushahiditeam.aha.io/features/PROD-41

@coveralls
Copy link

Coverage Status

Coverage remained the same at 20.346% when pulling 92d8790 on feat-add-translations-to-minimal into 7fe225e on v5.

@leninpaulino leninpaulino requested a review from rowasc July 22, 2020 12:12
@@ -24,6 +24,7 @@ public function toArray($request)
'id' => $this->id,
'name' => $this->name,
'description' => $this->description,
'translations' => new TranslationCollection($this->translations),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HA, nice catch!

@rowasc rowasc merged commit 9f8c3de into v5 Jul 22, 2020
@leninpaulino leninpaulino deleted the feat-add-translations-to-minimal branch July 22, 2020 21:04
@tuxpiper tuxpiper modified the milestones: Next minor release, v5.1.0 Jun 4, 2021
@tuxpiper tuxpiper removed this from Accepted in Release track next up... 5.2.1 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants