Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: XAMPP documentation update and db configuration enhancement #4094

Merged
merged 2 commits into from Oct 20, 2020
Merged

docs: XAMPP documentation update and db configuration enhancement #4094

merged 2 commits into from Oct 20, 2020

Conversation

arelsirin
Copy link

@arelsirin arelsirin commented Oct 9, 2020 •
edited by rowasc

This pull request makes the following changes:

  • XAMPP documentation update
  • DB configuration extension to support DB_SOCKET and different DB_PORT than 3306 (mysql default one)

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

Aha! Link: https://ushahiditeam.aha.io/features/PROD-848

@coveralls
Copy link

coveralls commented Oct 9, 2020 •
edited

Coverage Status

Coverage remained the same at 20.245% when pulling 61a41f3 on 0000-config-update into c1efce7 on develop.

@rowasc rowasc requested a review from tuxpiper October 9, 2020 15:42
@rowasc
Copy link
Contributor

rowasc commented Oct 9, 2020

@arelsirin thanks ! Assigning David since he may have things to say :D (mostly if we need to modify other scripts etc) .

tuxpiper
tuxpiper approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, this makes sense 👍

@rowasc rowasc added this to the Parking Lot milestone Oct 13, 2020
@rowasc rowasc merged commit 4896c51 into develop Oct 20, 2020
@rowasc rowasc deleted the 0000-config-update branch October 20, 2020 02:50
@tuxpiper tuxpiper moved this from Accepted to Released in Release track next up... 5.2.1 Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxpiper tuxpiper tuxpiper approved these changes

Assignees

@rowasc rowasc

Labels
None yet
Projects
Release track next up... 5.2.1
Released
Milestone
zz-archived
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arelsirin @coveralls @rowasc @tuxpiper @arelsirin-tk