[WIP] Harmonize solvers #1030
Open
[WIP] Harmonize solvers #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging prevents app from reporting exception to commandline
PETSc applies preconditioners by default
Shift to relative imports
We should stop nannying (or inherit ABC)
Different solver suites have different preconditioners, so too complicated to try to capture all in a single loop. Choose suite and preconditioner at calling level.
It was only ever an alias, anyway
RHS >> initial residual, so solver never does anything with (new) default criterion for convergence.
Still passes and doesn't throw obnoxious warnings from PETSc or Trilinos
It just gets in the way
Default solver tolerances have been relaxed from 1e-10 to 1e-5 to agree with default of most solver suites. This should save on compute time and, in most cases, this is adequate for existing tests to pass. Where it is not, either adjust the solver or adjust the test.
Originally tried to make it do logging, too, but I couldn't figure out how to get it to log in the correct scope. Separating timing from logging substantially simplifies the logic at a modest cost in LoC at point of use.
Terms should, in principle, be solvable for different variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.