Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure vector is dtype float before matrix multiply #544

Merged
merged 1 commit into from Jan 5, 2018
Merged

Ensure vector is dtype float before matrix multiply #544

merged 1 commit into from Jan 5, 2018

Conversation

guyer
Copy link
Member

@guyer guyer commented Jan 5, 2018

Fixes #543

@guyer guyer assigned guyer, wd15 and tkphd and unassigned guyer Jan 5, 2018
@wd15
Copy link
Contributor

wd15 commented Jan 5, 2018

@guyer, you've assigned me to this - do you want me to review?

@tkphd
Copy link
Contributor

tkphd commented Jan 5, 2018 •
edited

It's unclear to me why this should be a hard-coded requirement. Are FiPy users forbidden from composing problems in terms of integer variables?

Oh, #543. Got it.

@tkphd tkphd self-requested a review January 5, 2018 17:31
@guyer guyer merged commit 0f839f2 into usnistgov:develop Jan 5, 2018
@guyer guyer deleted the issue543-Epetra_Vector_cant_be_integer branch January 5, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkphd tkphd tkphd approved these changes

Assignees

@wd15 wd15

@tkphd tkphd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guyer @wd15 @tkphd