Issue488 gmsh meshing changed #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently when written, Gmsh didn't produce the expected grid, but now it does (although still not precisely at the spacing requested)
wd15
approved these changes
May 30, 2018
MethodSince this contribution changes FiPy's behavior depending on the Gmsh version, $ git checkout develop
$ for d in ~/repositories/gmsh/gmsh-*
> do
> cp $d/bin/gmsh /users/tnk10/.conda/envs/fipy/bin/gmsh
> python setup.py test &> test_develop_$(basename $d).log
> done
$ git checkout issue488_gmsh-meshing-changed
$ for d in ~/repositories/gmsh/gmsh-*
> do
> cp $d/bin/gmsh /users/tnk10/.conda/envs/fipy/bin/gmsh
> python setup.py test &> test_issue488_$(basename $d).log
> doneResultsAt a minimum, this contribution should not adversely affect the test results. $ for f in test_develop_gmsh-*.log
> do
> diff -y --suppress-common-lines $f ${f/develop/issue488} > diff_${f/develop_/}
> doneGmsh v2.7.0 (2013-03-08)Passed: fewer failuresGmsh v2.7.1 (2013-05-12)Passed: fewer failuresGmsh v2.8.0 (2013-07-09)Passed: fewer failuresGmsh v2.11.0 (2015-11-07)Passed: fewer failuresGmsh v3.0.6 (2017-11-05)Passed: fewer failures |
tkphd
approved these changes
May 31, 2018
|
Fixes #488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only apply mesh epsilon for older versions of gmsh
Fixes #488