-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CHANGELOG and tool to generate from issues and pull requests #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't extract date of tags (PyGithub/PyGithub#907 (comment)) and parsing ISO 8601 dates is annoying. Let Pandas do it.
`since` is not an option
Milestone of '*' does not return issues with no milestone set
tkphd
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor quibbles, but this looks good to me.
Nested double quotes seemed to work, but [looked odd in GitHub](usnistgov#600 (comment))
tkphd
approved these changes
Oct 1, 2018
@guyer, the output from flake8, pylint and reformatted with black. |
wd15
requested changes
Oct 3, 2018
@wd15 Thanks for the linting. That's an exercise for another day, I think. |
wd15
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this after trying and giving up on
Too many of them are focused on commits and advocate throwing away history with squash merges. The others are about formatting in sphinx, but not about getting the data. Even the sphinx formatting didn't really work, so I did it all by hand.