Fix Robin errors #615
Merged
Fix Robin errors #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volume integral of divergence is equal to surface integral of normal flux is approximately equal to sum over faces...
Divergence of a scalar field is unreliable. Multiplying by surface normal seems to resolve that.
tkphd
approved these changes
Dec 10, 2018
|
@tkphd Thanks for the suggested line wrappings. I've made some more pervasive changes to hopefully make this a bit clearer. Please take another look. |
tkphd
approved these changes
Dec 10, 2018
wd15
requested changes
Dec 11, 2018
tkphd
approved these changes
Dec 13, 2018
wd15
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some issues observed by @cashTangoTangoCash in RobinBoundaryConditionsFiPyUsageConvectionBC.pdf