Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ImportError before trying to unpack solvers #768

Merged
merged 1 commit into from Dec 1, 2020
Merged

Raise ImportError before trying to unpack solvers #768

merged 1 commit into from Dec 1, 2020

Conversation

guyer
Copy link
Member

@guyer guyer commented Dec 1, 2020

If no solver is found, raise ImportError before trying to use
(non-existent) solvers.

@guyer
Raise ImportError before trying to unpack solvers
2f92256 
If no solver is found, raise ImportError before trying to use
(non-existent) solvers.
@guyer guyer requested review from wd15 and tkphd December 1, 2020 18:14
tkphd
tkphd approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@guyer guyer merged commit 3bbef28 into usnistgov:master Dec 1, 2020
@guyer guyer deleted the FixSolverImportError branch December 1, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wd15 wd15 wd15 approved these changes

@tkphd tkphd tkphd approved these changes

Assignees
No one assigned
Labels
bug solvers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guyer @wd15 @tkphd