Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colorbar argument to valid value #829

Merged

Conversation

guyer
Copy link
Member

@guyer guyer commented Nov 18, 2021

Somehow missed in 65e1a48

Fixes #828

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@guyer guyer requested review from tkphd and wd15 November 18, 2021 15:33
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Build errors appear to be related to the heat death of Python 2.7.

examples/flow/stokesCavity.py Outdated Show resolved Hide resolved
Vector field doesn't use a colorbar.
Velocity vector field looks terrible at default scale.
`scale=` argument is ignored by all viewers that don't use it.
@guyer guyer merged commit 6809b18 into master Nov 30, 2021
@guyer guyer deleted the issue828-colorbar_True_no_longer_works_Stokes_flow_example branch November 30, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colorbar=True no longer works Stokes flow example
3 participants