Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get gmsh version from stderr or stdout #846

Merged
merged 3 commits into from Apr 4, 2022
Merged

Get gmsh version from stderr or stdout #846

merged 3 commits into from Apr 4, 2022

Conversation

guyer
Copy link
Member

@guyer guyer commented Apr 1, 2022

Since Gmsh 4.9.0 gmsh -version reports to stdout instead of stderr, which causes FiPy to fail the version check.

@guyer guyer requested review from tkphd and wd15 April 1, 2022 23:40
@wd15
Copy link
Contributor

wd15 commented Apr 4, 2022

I get an error on FAIL: Gmsh2D (fipy.meshes.gmshMesh), but it's on both master and this branch so not a regression.

@guyer
Copy link
Member Author

guyer commented Apr 4, 2022

I get an error on FAIL: Gmsh2D (fipy.meshes.gmshMesh), but it's on both master and this branch so not a regression.

What's the error? The CIs are all broken (again!), but none of it is a Gmsh FAIL AFAICT. macOS gets a Gmsh ERROR because of dictionary changed size during iteration.

@guyer guyer merged commit a5d8e73 into master Apr 4, 2022
@guyer guyer deleted the new_gmsh branch April 4, 2022 15:22
@guyer guyer mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wd15 wd15 wd15 approved these changes

@tkphd tkphd Awaiting requested review from tkphd

Assignees
No one assigned
Labels
bug meshes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guyer @wd15