Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually clean up PETSc objects #899

Conversation

guyer
Copy link
Member

@guyer guyer commented Jan 12, 2023

Garbage collection works differently (worse) in petsc4py 3.18.3 than in 3.17.4.

Fixes #896

Garbage collection works differently (worse) in petsc4py 3.18.3
than in 3.17.4.

Fixes usnistgov#896
@guyer guyer requested review from tkphd and wd15 January 12, 2023 15:43
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have not tested it to check for memory leaks.

@guyer guyer merged commit 4db188c into usnistgov:master Jan 12, 2023
@guyer guyer deleted the issue896-Poor_garbage_collection_with_petsc4py_3.18.3 branch January 12, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants