Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numpy 1.25 issues #930

Merged
merged 7 commits into from Jun 26, 2023
Merged

Fix numpy 1.25 issues #930

merged 7 commits into from Jun 26, 2023

Conversation

guyer
Copy link
Member

@guyer guyer commented Jun 22, 2023 •
edited

NumPy 1.25 brings deprecations and changes that breaks FiPy.

Fixes #931

@guyer guyer mentioned this pull request Jun 22, 2023
Closed
@guyer guyer assigned wd15 and tkphd Jun 23, 2023
@guyer
Copy link
Member Author

guyer commented Jun 26, 2023

I don't know what's going on with nix

@guyer
Copy link
Member Author

guyer commented Jun 26, 2023

I also don't know why the PDF docs are timing out but, given the imminent migration to NISTtheDocs2Death, I'm not going to worry about it.

@guyer
Copy link
Member Author

guyer commented Jun 26, 2023

@wd15 & @tkphd: Any new installation of FiPy will fail without this PR. While there are workarounds, I'd appreciate a quick code review.

tkphd
tkphd approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me, in light of the deprecation notices. Good catch!

@guyer guyer merged commit 729a2e9 into master Jun 26, 2023
17 of 23 checks passed
@guyer guyer deleted the fix_numpy_1_25_issues branch June 26, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkphd tkphd tkphd approved these changes

Assignees

@wd15 wd15

@tkphd tkphd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FiPY not working with numpy 1.25
3 participants
@guyer @tkphd @wd15