Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sign error in documentation of Robin condition #968

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix sign error in documentation of Robin condition #968

merged 1 commit into from
Oct 16, 2023

Conversation

guyer
Copy link
Member

@guyer guyer commented Oct 16, 2023

@guyer guyer requested review from wd15 and tkphd October 16, 2023 16:11
tkphd
tkphd approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wd15
Copy link
Contributor

wd15 commented Oct 16, 2023

I can't find anything wrong. Seems to render correctly. I noticed that the "wiki" link on the front page doesn't seem to go anywhere.

@guyer
Copy link
Member Author

guyer commented Oct 16, 2023

I noticed that the "wiki" link on the front page doesn't seem to go anywhere.

Oh! Yeah, I'll bet there are a bunch like that (#969).

@guyer guyer merged commit 7f3fc9a into master Oct 16, 2023
16 of 24 checks passed
@guyer guyer deleted the issue967-Sign_error_in_Robin_condition branch October 16, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wd15 wd15 wd15 approved these changes

@tkphd tkphd tkphd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign error in Robin condition
3 participants
@guyer @wd15 @tkphd