Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ONT browser basecaller #24

Conversation

MrTeej
Copy link

@MrTeej MrTeej commented Dec 10, 2021

No description provided.

@MrTeej
Copy link
Author

MrTeej commented Dec 10, 2021

Updated the parcel package, and re-built the dist files to stop errors when we import and build the module into another project.

@bmaranville
Copy link
Member

Would you mind trying out the esbuild branch? I just pushed it, and if it works for you I'd like to switch to esbuild from parcel because it is much smaller and has less dependencies (node_modules went from >200MB to 14MB)

Please let me know if you are able to import and build using the module in that branch - thanks very much!

@anddigital-jh
Copy link

Would you mind trying out the esbuild branch? I just pushed it, and if it works for you I'd like to switch to esbuild from parcel because it is much smaller and has less dependencies (node_modules went from >200MB to 14MB)

Please let me know if you are able to import and build using the module in that branch - thanks very much!

Sure, we'll check it out

@MrTeej
Copy link
Author

MrTeej commented Dec 16, 2021

I've tested the other PR (#25), and left a comment on the PR; it works if we update our projects bundler to include "@babel/plugin-proposal-class-properties"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants