Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build project with esbuild instead of parcel #25

Merged
merged 3 commits into from
Dec 20, 2021
Merged

build project with esbuild instead of parcel #25

merged 3 commits into from
Dec 20, 2021

Conversation

bmaranville
Copy link
Member

See if this also fixes the issues in #24

@MrTeej
Copy link

MrTeej commented Dec 16, 2021

So this works if I update our web builder (craco with webpack) to include "@babel/plugin-proposal-class-properties"

@bmaranville
Copy link
Member Author

@MrTeej I updated the browser build to target es2020, which is the lowest version that supports BigInt (required!) but still low enough that it will transform the class properties, so it shouldn't need "@babel/plugin-proposal-class-properties" on your end.

@MrTeej
Copy link

MrTeej commented Dec 17, 2021

Thanks @bmaranville, I'll test this out soon and let you know if it works.

On a separate note (not sure what the best way to contact you is) - We're looking to extend jsfive to support VBZ compression. What would the best way be to go about this?

@MrTeej
Copy link

MrTeej commented Dec 17, 2021

Hi @bmaranville unfortunately this change didn't work without the babel plugin.

@bmaranville
Copy link
Member Author

@MrTeej feel free to open a new issue for the VBZ compression feature request, and we can start a discussion in that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants