-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper handling of group links during profile resolution #65
Comments
Added explicit |
…profile resolution to improve performance. - The current solution now reuses the index reducing the need to walk the document multiple times. - The index code has been simplified to reduce a significant amount of redundant method calls. - The various visitors now use a common set of base implementation classes making maintenance easier. Added support for property name="keep" in the reference handler. Fixed reference handling for orphaned groups during flat structuring. Resolves usnistgov#65.
…profile resolution to improve performance. - The current solution now reuses the index reducing the need to walk the document multiple times. - The index code has been simplified to reduce a significant amount of redundant method calls. - The various visitors now use a common set of base implementation classes making maintenance easier. Added support for property name="keep" in the reference handler. Fixed reference handling for orphaned groups during flat structuring. Resolves usnistgov#65.
* Refactored the visitors used to process catalogs and profiles during profile resolution to improve performance. - The current solution now reuses the index reducing the need to walk the document multiple times. - The index code has been simplified to reduce a significant amount of redundant method calls. - The various visitors now use a common set of base implementation classes making maintenance easier. Added support for property name="keep" in the reference handler. Fixed reference handling for orphaned groups during flat structuring. Resolves #65. * Fixed compile, Checkstyle, PMD, and Spotbugs errors. * Updated to latest OSCAL to get test content fixes.
@GaryGapinski and @openprivacy Try the following build. According to my unit tests, I believe this issue is fixed. |
cli-core-0.2.1-SNAPSHOT fixes the issue (no more warnings) but I was surprised at the number of additional ODPs that popped up (see attachment edit: adding commands to create above file: FROM: https://github.com/CMSgov/ars-machine-readable/tree/main/ODP-extract
|
@openprivacy The resolver was not processing some nodes previously causing spurious results due to a number of issues which have been corrected in the latest. This could explain why some parameters were previously ignored. Let me know if you see anything that is out of place. |
I tried that build with this profile and saw no error messages.
That profile has
The output resolved profile contained no groups. All selected controls (352) and parameter values (568) were present in the resolved profile. Group references were qualified as
The input profile contained a A test xml-model processing instruction
A test xml-stylesheet processing instruction
|
I can confirm I was able to recreate the same behavior as reported by @GaryGapinski in #65 (comment) with the snapshot release provided in #65 (comment). |
…profile resolution to improve performance. - The current solution now reuses the index reducing the need to walk the document multiple times. - The index code has been simplified to reduce a significant amount of redundant method calls. - The various visitors now use a common set of base implementation classes making maintenance easier. Added support for property name="keep" in the reference handler. Fixed reference handling for orphaned groups during flat structuring. Resolves usnistgov#65.
* Refactored the visitors used to process catalogs and profiles during profile resolution to improve performance. - The current solution now reuses the index reducing the need to walk the document multiple times. - The index code has been simplified to reduce a significant amount of redundant method calls. - The various visitors now use a common set of base implementation classes making maintenance easier. Added support for property name="keep" in the reference handler. Fixed reference handling for orphaned groups during flat structuring. Resolves #65. * Fixed compile, Checkstyle, PMD, and Spotbugs errors. * Code cleanup.
Describe the bug
When using a profile, such as the ARS moderate profile, oscal-cli produces the following errors.
This is due to the three references (in
<a>
elements) in the catalog which targetgroup
elements. The groups are removed since the structuring directiveflat
is used.Who is the bug affecting?
Users of the oscal-cli tool and this library performing profile resolution.
What is affected by this bug?
Any profile using the
flat
structuring directive with a group reference.When does this occur?
See above.
How do we replicate the issue?
See above.
Expected behavior (i.e. solution)
Links to groups should be resolved to absolute URLs pointing to the original catalog, replacing the current links.
Other Comments
None.
The text was updated successfully, but these errors were encountered: