Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved profile resolution visitors #69

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Sep 8, 2022

Committer Notes

  • Refactored the visitors used to process catalogs and profiles during profile resolution to improve performance.
    • The current solution now reuses the index reducing the need to walk the document multiple times.
    • The index code has been simplified to reduce a significant amount of redundant method calls.
    • The various visitors now use a common set of base implementation classes making maintenance easier.
    • The new visitation approach is much more efficient than the old design. Performance should be 2x-4x better now.
  • Added support for property name="keep" in the reference handler.
  • Fixed reference handling for orphaned groups during flat structuring. Resolves Improper handling of group links during profile resolution #65.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

@david-waltermire david-waltermire linked an issue Sep 9, 2022 that may be closed by this pull request
@david-waltermire david-waltermire changed the title Improved profile resolution visitors Sep 9, 2022
…profile resolution to improve performance.

- The current solution now reuses the index reducing the need to walk the document multiple times.
- The index code has been simplified to reduce a significant amount of redundant method calls.
- The various visitors now use a common set of base implementation classes making maintenance easier.
Added support for property name="keep" in the reference handler.
Fixed reference handling for orphaned groups during flat structuring. Resolves usnistgov#65.
@david-waltermire david-waltermire force-pushed the issue65-refactor--resolution-visitors branch from 8ad2d23 to 80f6b50 Compare September 9, 2022 13:25
@david-waltermire david-waltermire merged commit d5fd430 into usnistgov:develop Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper handling of group links during profile resolution
1 participant