Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

June 2024 in-progress merge #120

Merged
merged 9 commits into from
Jun 11, 2024

Conversation

wendellpiez
Copy link
Collaborator

Committer Notes

Last alignment of several PRs merging?

This PR adds new copies of resources and makes a couple of small updates. After merging, we can drop this WIP branch and start another one targeting the merge branch.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

wendellpiez and others added 5 commits June 6, 2024 17:23
Several months of work building InspectorXSLT using test-driven-development.
Also includes considerable work on XSpec support including XProc and Saxon runtimes, scripts and CI/CD support.

---------

Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
*** Many improvements to XSLTs and XSpec reporting scripts

* Add permissions for EnricoMi/publish-unit-test-result-action

Using the guidance from the action's instructions:
https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches

* Add artifact event pull for EnricoMi/publish-unit-test-result-action

Using the guidance from the action's instructions:

https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches

* Ensure XSpec test results comment always made on PR
* [WIP] Dedupe event trigger and inline JUnit XML processing in CI workflow

---------

Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
…gov#73)

Several months of work building InspectorXSLT using test-driven-development.
Also includes considerable work on XSpec support including XProc and Saxon runtimes, scripts and CI/CD support.

---------

Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
@wendellpiez wendellpiez requested a review from a team as a code owner June 10, 2024 15:07
Copy link

github-actions bot commented Jun 10, 2024

XSpec Test Results

  5 files  ±0   90 suites  ±0   0s ⏱️ ±0s
229 tests ±0  213 ✅ ±0  16 💤 ±0  0 ❌ ±0 
239 runs  ±0  223 ✅ ±0  16 💤 ±0  0 ❌ ±0 

Results for commit 98fd1f1. ± Comparison against base commit 74f3a11.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor feedback and difference of opinion I will couch with "your codebase, your rules," so I approve anyway.

wendellpiez and others added 3 commits June 10, 2024 17:51
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
…spector.sh

Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
@wendellpiez wendellpiez mentioned this pull request Jun 10, 2024
3 tasks
@wendellpiez wendellpiez merged commit 52c9f6d into usnistgov:merge-June2024 Jun 11, 2024
3 checks passed
@wendellpiez wendellpiez deleted the merge-June2024 branch June 11, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants