Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent error in output when using JSON parameter #51

Conversation

nikitawootten-nist
Copy link
Collaborator

Committer Notes

This is a recreation of @kylelaker's PR (usnistgov/metaschema#394) with some additional changes, namely correcting the XSL wrapper paths.

Previous text:

Previously, if file was not specified (and json was), an error would
be emitted about the file not being found. This was erroneous as only
the JSON input should have been considered. This applies a small fix to
remediate that, given by Wendell in usnistgov/OSCAL#1849.

I am unsure whether this is the desired long-term fix but I figured
opening a PR to memorialize the patch may be useful.

Co-authored-by: Wendell Piez wendell.piez@nist.gov

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

Also corrected broken paths in the xsl wrappers

Co-authored-by: Kyle Laker <kyle@laker.email>
Co-authored-by: Wendell Piez <wendell.piez@nist.gov>
@nikitawootten-nist nikitawootten-nist requested a review from a team as a code owner July 25, 2023 15:17
@nikitawootten-nist
Copy link
Collaborator Author

@wendellpiez and I reviewed and tested on a call. Merging now.

@nikitawootten-nist nikitawootten-nist merged commit ac4bd7e into usnistgov:develop Jul 25, 2023
@nikitawootten-nist nikitawootten-nist deleted the json-to-xml-converter-patch branch July 25, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant