Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent error in converter output when using JSON parameter #394

Closed
wants to merge 1 commit into from

Conversation

kylelaker
Copy link
Contributor

Previously, if file was not specified (and json was), an error would
be emitted about the file not being found. This was erroneous as only
the JSON input should have been considered. This applies a small fix to
remediate that, given by Wendell in usnistgov/OSCAL#1849.

I am unsure whether this is the desired long-term fix but I figured
opening a PR to memorialize the patch may be useful.

Co-authored-by: Wendell Piez wendell.piez@nist.gov

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

Previously, if `file` was not specified (and `json` was), an error would
be emitted about the file not being found. This was erroneous as only
the JSON input should have been considered. This applies a small fix to
remediate that, given by Wendell in usnistgov/OSCAL#1849.

I am unsure whether this is the desired long-term fix but I figured
opening a PR to memorialize the patch may be useful.

Co-authored-by: Wendell Piez <wendell.piez@nist.gov>
@kylelaker kylelaker changed the title Prevent error in output when using JSON parameter Prevent error in converter output when using JSON parameter Jul 12, 2023
@david-waltermire
Copy link
Collaborator

@nikitawootten-nist and @wendellpiez This needs to be ported to the usnistgov/metaschema-xslt repo, since things are moving there.

@wendellpiez
Copy link
Collaborator

@david-waltermire-nist Indeed! Please move the Issue or instruct me in how to do so?

@nikitawootten-nist
Copy link
Contributor

Superseded by usnistgov/metaschema-xslt#51, which will be a part of the upcoming OSCAL 1.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants