-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
native Windows compilation #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the problem being solved in e.g. get_prefs.c. Does MSVC not have standard library calls like read()?
Other than that I'm ready to merge.
Something like that. I think perhaps My REAME.windows.md did record some motivations.
Other advantages would also be Github actions for automatic testing - see https://github.com/cmacdonald/trec_eval/actions |
My search history for 16th June is full of read vs fread. I think read is a syscall and varies by platform; fread is more reliable and behaves in a standard way. Similar discussion about lseek vs fseek. (It might have been lseek that drove the change.) GitHub actions shows this version passing on Windows, Ubuntu and Mac. |
I do like the automatic testing doodad, that's a winner. Merging! |
woop. Do you need a version for version 10 branch? |
I'm going to try to cherrypick it into v10-dev, if that doesn't work I'll hit you up. This seems good enough it should go in both. I already packaged up a new 9.0.8 release. |
Sure, let me know if you need help.
Other thing I want to suggest/help with is to use github actions to build the executables automatically (Windows, in particular).
Craig
…________________________________
From: Ian Soboroff <notifications@github.com>
Sent: 03 September 2020 21:59
To: usnistgov/trec_eval <trec_eval@noreply.github.com>
Cc: Craig Macdonald <Craig.Macdonald@glasgow.ac.uk>; Author <author@noreply.github.com>
Subject: Re: [usnistgov/trec_eval] native Windows compilation (#25)
I'm going to try to cherrypick it into v10-dev, if that doesn't work I'll hit you up. This seems good enough it should go in both. I already packaged up a new 9.0.8 release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#25 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEXTCUC7MW3RMHOI55J7DDSD77SRANCNFSM4OAQE4HA>.
|
Please consider this pull request for review. This PR addresses the compilation and running of trec_eval on Windows, when using the standard Microsoft Visual Studio toolchain (e.g. rather than cygwin). This is required in order to get pytrec_eval working under Windows (see cvangysel/pytrec_eval#27).
The changes to trec_eval include:
All new files are included in a separate "windows" sub-directory.
I also created a Github Action workflow that does compilation and testing on Linux, Mac and Windows (see .github/workflows). The last run is at https://github.com/cmacdonald/trec_eval/actions/runs/137772843
There were a lot of commits, so you might consider squash-merge to make the revision history simpler.
I would hope that once we have this merged, we can improve the action to put trec_eval.exe file in the Github releases directory when you do each release.