Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties vs. Relationships #15

Closed
harold-owen opened this issue Aug 2, 2018 · 2 comments
Closed

Properties vs. Relationships #15

harold-owen opened this issue Aug 2, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@harold-owen
Copy link
Collaborator

harold-owen commented Aug 2, 2018

There appears to be a possible misuse of the terms "Properties" and "Relationships" throughout the vulntology. Consider Vulnerability has a vulnerability-identifier, but in vulnerability.md, the identifier is not listed under the Properties heading. Instead, each of the so called Properties is actually a relationship (line) on the graph.

Note also in explanation.md the term Properties is defined in terms of a relationship:

Properties: A connection relating a Type to a SubType or an Object to a Type.

See also Issue 9 in which lines on the graph are mislabeled "Property".

@harold-owen harold-owen added the bug Something isn't working label Aug 2, 2018
@david-waltermire
Copy link
Collaborator

I also raised the concern about vulnerability identifiers in #3. I agree that we need to handle identifiers as actual properties and/or relationships.

Chris-Turner-NIST added a commit that referenced this issue Aug 31, 2018
…ns of type/subtype/values/properties. Also added changes to handle issues #3, #15, #9, #16 and #14
@Chris-Turner-NIST
Copy link
Collaborator

Due to the confusion I have removed any references in the visual to the inherent identifiers for each object. I have also modified the visual to better describe what is a relationship and what is a property. I have also modified the text in explanation.md to imply a difference between a property and a relationship. I believe there will still be some confusion here since properties do have their own desired cardinality constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants