-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.6.0 #5454
Merged
Merged
Release 3.6.0 #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync develop 3.5.0
- Meet color contrast requirements
Bumps [stylelint](https://github.com/stylelint/stylelint) from 14.13.0 to 15.10.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@14.13.0...15.10.1) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
- Allows users to set the element where the component pulls headers
- Make the name more intuitive
USWDS - Input mask: Fix hover state
USWDS - Icon list: Allow $theme-body-font-size to accept all size tokens
USWDS - Forms: Remove high-contrast disabled border from %block-input-styles
USWDS - In-page navigation: Exclude hidden headers
USWDS - Card: Fix `$theme-card-border-width` calculation errors
…age-nav-parent
USWDS: Fix disabled theme color settings
USWDS - In-page navigation: Add an option to designate the main content element
USWDS - Utilities: Generate font-[family]-[size] classes
amyleadem
reviewed
Aug 23, 2023
amyleadem
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a question about the listed vulnerabilities below:
- Confirmed all USWDS items tagged as part of 3.6.0 have been merged into
develop
- Confirmed that
release-3.6.0
branch is up-to-date withdevelop
- Confirmed the hash in the release notes matches the
.txt
file and the.tgz
file - Confirmed the contents in the
.tgz
are present
Release description:
- Confirmed that user-facing changes from the 3.6.0 milestone are included in the release notes (11 of the 13 milestone items)
- Confirmed the listed vulnerabilities are accurate
- I might be looking at the wrong thing, but when I run
npm install
on therelease-3.6.0
branch in uswds, I get "30 vulnerabilities (1 moderate, 29 high)" - When I run
npm install "@uswds/uswds@github:uswds/uswds#release-3.6.0"
on a test project, I get "7 high severity vulnerabilities"
- I might be looking at the wrong thing, but when I run
- Confirmed the listed dependency changes are accurate
- Confirmed a11y items have been correctly identified
- Confirmed breaking items have been correctly identified and give description of the break
- Confirmed no spelling or grammatical errors
Update: I was able to see |
amyleadem
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in USWDS 3.6.0
Features
usa-in-page-navigation
display:none
orvisibility:hidden
will now be excluded from the list of links in the component. (#5393)usa-in-page-navigation
data-main-content-selector
attribute to the in-page navigation component. This attribute allows users to designate which element they want the component to pull headers from. If the attribute is not defined, the component will pull headers from the<main>
element. (#5387)usa-select
Bug fixes
usa-button
,usa-checkbox
,usa-combo-box
,usa-file-input
,usa-input
,uswds-core
$theme-color-disabled-lighter
and$theme-color-disabled-darker
settings, and addeddisabled-lighter
anddisabled-darker
tokens.usa-pagination
$theme-pagination-background-color
. Users should confirm that project pagination colors display as expected. (#5358)usa-card
,uswds-core
$theme-card-border-width
from accepting0
or string tokens. (#5325)usa-combo-box
,usa-input
,usa-input-prefix-suffix
,usa-range
,usa-select
,usa-textarea
,uswds-core
usa-icon-list
$theme-body-font-size
to accept2xs
and3xs
size tokens. (#5363)usa-input-mask
usa-memorable-date
uswds-utilities
font-[family]-[size]
utility classes to not generate font-family rules. (#5388)Breaking changes
Warning
Disabled theme settings. This release updates USWDS disabled color settings and tokens to conform to our standard naming convention. If your project configures disabled color settings or uses disabled color tokens, you probably need to update your code. Here is a table showing how we reassigned disabled color values:
All references to the previous settings have been replaced with references to their corresponding new settings. This means that if you previously customized
$theme-color-disabled
, you should now instead assign that custom value to$theme-color-disabled-lighter
. Additionally, all references to the“disabled”
color token in your Sass should now be replaced with“disabled-lighter”
.Please note that all disabled states are now expected to meet minimum color contrast requirements for text (4.5:1). If you have customized any of the disabled color values, please confirm that your disabled elements meet these contrast standards.
Dependencies and security
0
vulnerabilities in regular dependencies (dependencies for USWDS projects installed withnpm install @uswds/uswds
)4 moderate, 29 high
vulnerabilities in devDependencies (development dependencies)Release TGZ SHA-256 hash:
a6c303c350063a1f42baa0de8f1c860d91b06fd85f330b947209a8886f0e290a