Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.6.0 #5454

Merged
merged 118 commits into from
Aug 23, 2023
Merged

Release 3.6.0 #5454

merged 118 commits into from
Aug 23, 2023

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Aug 18, 2023

What's new in USWDS 3.6.0

Features

Package A11y Breaking Description
usa-in-page-navigation No No Updated JavaScript to exclude hidden headers from the in-page navigation link list. Any header with a style of display:none or visibility:hidden will now be excluded from the list of links in the component. (#5393)
usa-in-page-navigation No No Added the optional data-main-content-selector attribute to the in-page navigation component. This attribute allows users to designate which element they want the component to pull headers from. If the attribute is not defined, the component will pull headers from the <main> element. (#5387)
usa-select No No Added ellipses to overflow text in the multiple variant of the select component. This provides a clear indication to users that there is text that extends beyond the select width. (#5268)

Bug fixes

Package A11y Breaking Description
usa-button, usa-checkbox, usa-combo-box, usa-file-input, usa-input, uswds-core Yes Yes Updated default disabled color settings values. This change also fixed configuration errors with disabled color settings, added $theme-color-disabled-lighter and $theme-color-disabled-darker settings, and added disabled-lighter and disabled-darker tokens.

⚠️ The names and values of disabled settings and tokens have changed and will need to be updated if they are customized in your project. See the "Breaking changes" section below for more details. (#5402)
usa-pagination Yes Potentially Updated the ellipsis color to meet color contrast requirements. Additionally, this change updated styles to respect the value added to $theme-pagination-background-color. Users should confirm that project pagination colors display as expected. (#5358)
usa-card, uswds-core No No Fixed a bug that prevented $theme-card-border-width from accepting 0 or string tokens. (#5325)
usa-combo-box, usa-input, usa-input-prefix-suffix, usa-range, usa-select, usa-textarea, uswds-core Yes No Fixed a bug that caused standard text input variants to show disabled styles in forced colors mode. Now the disabled border color only shows when the element is disabled. (#5397)
usa-icon-list No No Updated icon list styles to allow $theme-body-font-size to accept 2xs and 3xs size tokens. (#5363)
usa-input-mask Yes No Fixed a bug in input mask that caused the hover state to show disabled styling. This change also improved the legibility of the component in forced colors mode. (#5378)
usa-memorable-date Yes No Updated memorable date styles to allow elements to wrap to multiple lines at narrow browser widths. (#5372)
uswds-utilities No No Fixed a bug that caused font-[family]-[size] utility classes to not generate font-family rules. (#5388)

Breaking changes

Warning

Disabled theme settings. This release updates USWDS disabled color settings and tokens to conform to our standard naming convention. If your project configures disabled color settings or uses disabled color tokens, you probably need to update your code. Here is a table showing how we reassigned disabled color values:

Default value Previously assigned to: Now assigned to:
"gray-20" $theme-color-disabled $theme-color-disabled-lighter
"gray-40" $theme-color-disabled-text-reverse $theme-color-disabled-light
"gray-50" $theme-color-disabled-text $theme-color-disabled
"gray-70" $theme-color-text-on-disabled $theme-color-disabled-dark

All references to the previous settings have been replaced with references to their corresponding new settings. This means that if you previously customized $theme-color-disabled, you should now instead assign that custom value to $theme-color-disabled-lighter. Additionally, all references to the “disabled” color token in your Sass should now be replaced with “disabled-lighter”.

Please note that all disabled states are now expected to meet minimum color contrast requirements for text (4.5:1). If you have customized any of the disabled color values, please confirm that your disabled elements meet these contrast standards.

Dependencies and security

Dependency name Previous version New version
@18f/identity-stylelint-config 1.0.0 2.0.0
postcss 8.4.0 8.4.19
stylelint 14.13.0 15.10.1

0 vulnerabilities in regular dependencies (dependencies for USWDS projects installed with npm install @uswds/uswds)

4 moderate, 29 high vulnerabilities in devDependencies (development dependencies)


Release TGZ SHA-256 hash: a6c303c350063a1f42baa0de8f1c860d91b06fd85f330b947209a8886f0e290a

mahoneycm and others added 30 commits May 2, 2023 13:58
- Meet color contrast requirements
Bumps [stylelint](https://github.com/stylelint/stylelint) from 14.13.0 to 15.10.1.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@14.13.0...15.10.1)

---
updated-dependencies:
- dependency-name: stylelint
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
- Allows users to set the element where the component pulls headers
- Make the name more intuitive
amyleadem and others added 15 commits August 10, 2023 09:35
USWDS - Input mask: Fix hover state
USWDS - Icon list: Allow $theme-body-font-size to accept all size tokens
USWDS - Forms: Remove high-contrast disabled border from %block-input-styles
USWDS - In-page navigation: Exclude hidden headers
USWDS - Card: Fix `$theme-card-border-width` calculation errors
USWDS: Fix disabled theme color settings
USWDS - In-page navigation: Add an option to designate the main content element
USWDS - Utilities: Generate font-[family]-[size] classes
@thisisdano thisisdano requested a review from mejiaj August 18, 2023 21:03
@thisisdano thisisdano marked this pull request as draft August 18, 2023 21:14
@thisisdano thisisdano requested review from amyleadem and removed request for mejiaj August 23, 2023 17:33
@thisisdano thisisdano marked this pull request as ready for review August 23, 2023 17:42
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a question about the listed vulnerabilities below:

  • Confirmed all USWDS items tagged as part of 3.6.0 have been merged into develop
  • Confirmed that  release-3.6.0 branch is up-to-date with develop
  • Confirmed the hash in the release notes matches the .txt file and the .tgz file
  • Confirmed the contents in the .tgz are present

Release description:

  • Confirmed that user-facing changes from the 3.6.0 milestone are included in the release notes (11 of the 13 milestone items)
  • Confirmed the listed vulnerabilities are accurate
    • I might be looking at the wrong thing, but when I run npm install on the release-3.6.0 branch in uswds, I get "30 vulnerabilities (1 moderate, 29 high)"
    • When I run npm install "@uswds/uswds@github:uswds/uswds#release-3.6.0" on a test project, I get "7 high severity vulnerabilities"
  • Confirmed the listed dependency changes are accurate
  • Confirmed a11y items have been correctly identified
  • Confirmed breaking items have been correctly identified and give description of the break
  • Confirmed no spelling or grammatical errors

@amyleadem
Copy link
Contributor

Update: I was able to see 0 vulnerabilities in when I installed only "@uswds/uswds": "github:uswds/uswds#release-3.6.0" in the dependencies on my test project.

@thisisdano thisisdano merged commit eb8e4d4 into main Aug 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants