Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioner creates copy when used in @spawn() #93

Open
wlruys opened this issue Dec 9, 2021 · 0 comments
Open

Partitioner creates copy when used in @spawn() #93

wlruys opened this issue Dec 9, 2021 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@wlruys
Copy link
Contributor

wlruys commented Dec 9, 2021

This is an old bug discovered when Milinda was working on the QR App. Just documenting it now as we've starting talking about improving data partitioning.

Consider the following:

    mapper = LDeviceSequenceBlocked(nblocks, placement=gpu_list)
    A_blocked = mapper.partition_tensor(A) 
    @spawn(placement=A_blocked[i])

This will always cause an unnecessary copy of A_blocked[i] from the GPU to host when launching the task.

Maybe we need to introduce "( )" operators to distinguish when a copy is made or if it can be inferred otherwise.

@wlruys wlruys added bug Something isn't working enhancement New feature or request labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant