Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segbot_simulation_apps: target 'door_handler' should be more unique #19

Closed
jack-oquin opened this issue Apr 20, 2014 · 4 comments
Closed

Comments

@jack-oquin
Copy link
Member

This issue was raised by catkin_lint, because catkin library names are global to entire ROS distribution.

Including the entire package name, as catkin_lint suggests, is probably overkill. But, some project-oriented prefix seems reasonable. I suggest bwi_door_handler, unless this interface is really unique to the segbot, in which case segbot_simulation_door_handler might be appropriate.

@piyushk
Copy link
Member

piyushk commented Apr 20, 2014

bwi_door_handler is fine. This app eventually needs to be moved to a package called bwi_simulation_apps, but all in due time.

@jack-oquin
Copy link
Member Author

I agree. I don't want to fix it now, either, so I opened the issue to keep it from getting lost.

@piyushk
Copy link
Member

piyushk commented Mar 14, 2015

I'm closing this issue. I don't plan on fixing target name unique errors any more.

@piyushk piyushk closed this as completed Mar 14, 2015
@jack-oquin
Copy link
Member Author

It probably wouldn't hurt to add a bwi_ prefix to most of our target names. That way we never have to worry about catkin_make blowing up when building a large workspace containing lots of other packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants