Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a search bar on the results page #12

Closed
jai-dewani opened this issue May 14, 2020 · 3 comments · Fixed by #14
Closed

Adding a search bar on the results page #12

jai-dewani opened this issue May 14, 2020 · 3 comments · Fixed by #14
Assignees
@jai-dewani
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jai-dewani
Copy link
Contributor

Adding this feature will help users to search again without going back to the root page.
Maybe the same search bar can be just implemented/copied on the top of the results page
@utkarsh-raj
Copy link
Owner

Sounds right. Would you want to take this up @jai-dewani ?

@utkarsh-raj utkarsh-raj added enhancement New feature or request good first issue Good for newcomers labels May 14, 2020
@jai-dewani
Copy link
Contributor Author

Sure I would love to, but if you are going to port this to vue.js will all the changes we make to UI will be useless or they can be recycled in vue.js?

@utkarsh-raj
Copy link
Owner

We'll do out best to reuse the existing code as components, but don't let it keep you from working on this!

@jai-dewani jai-dewani mentioned this issue May 15, 2020
Merged
@utkarsh-raj utkarsh-raj linked a pull request May 16, 2020 that will close this issue
Add search bar at results page with a brand-logo #14
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jai-dewani jai-dewani

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add search bar at results page with a brand-logo jai-dewani/umusic
2 participants
@utkarsh-raj @jai-dewani