Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tagline to read site title #373

Closed
reasterbrooknc opened this issue Jul 5, 2024 · 6 comments · Fixed by #433
Closed

Update tagline to read site title #373

reasterbrooknc opened this issue Jul 5, 2024 · 6 comments · Fixed by #433
Assignees

Comments

@reasterbrooknc
Copy link

No description provided.

@reasterbrooknc
Copy link
Author

We're hesitant to change this core WP field name—@nc-mhenderson strongly recommends against it. All WP documentation that exists refers to "tagline."

To implement, would need to generate translation file so that all references to "tagline" are updated.

@pikemurdy
Copy link
Contributor

I understand. I don't want to change core.

But 'tagline' is weird for this. It's not a tagline, it's a parent unit. And it's caused confusion. Is there another route?

Also: Do we even know if Site Admins have the ability to edit this field (or section) or is it restricted to Super Admins like the Custom CSS section?

@reasterbrooknc
Copy link
Author

I understand. I don't want to change core.

But 'tagline' is weird for this. It's not a tagline, it's a parent unit. And it's caused confusion. Is there another route?

Also: Do we even know if Site Admins have the ability to edit this field (or section) or is it restricted to Super Admins like the Custom CSS section?

Another option would be to re-implement it by adding a field to the Customizer. So, instead of using the tagline, we'd add a field that said "parent," e.g. But it would be edited in the same place and in the same way as the tagline currently is.

@pikemurdy
Copy link
Contributor

I am more comfortable with that.

@nc-mhenderson nc-mhenderson linked a pull request Sep 3, 2024 that will close this issue
@reasterbrooknc
Copy link
Author

Ready for your review @pikemurdy

@pikemurdy
Copy link
Contributor

This is good. Much clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants