refactor v3 implementation #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Dylan-DPC-zz
approved these changes
May 3, 2018
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
May 3, 2018
215: refactor v3 implementation r=Dylan-DPC a=kinggoesgaming
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
<!--
As we are working towards a stable version of uuid, we require that you
open an issue, before submitting a pull request. If the pull request is
imcomplete, prepend the Title with WIP:
-->
**I'm submitting a ...**
- [ ] bug fix
- [ ] feature enhancement
- [ ] deprecation or removal
- [x] refactor
# Description
Move v3 implementation to the v3 module
# Motivation
Part of the grand refactor
# Tests
All tests, including v3 tests passing
# Related Issue(s)
#124
Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
LinusU
pushed a commit
to LinusU/uuid
that referenced
this pull request
Feb 26, 2020
This was previously fixed in uuidjs/uuid@880d24e , but was regrtessed in README_js.md and hence in the newly generated README.md Also reran `npm run-script prepare` to update README.md from the corrected version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hunar Roop Kahlon hunar.roop@gmail.com
I'm submitting a ...
Description
Move v3 implementation to the v3 module
Motivation
Part of the grand refactor
Tests
All tests, including v3 tests passing
Related Issue(s)
#124