Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tests are required for UUIDv7 implementation #9

Open
nurked opened this issue Aug 1, 2021 · 3 comments
Open

Better tests are required for UUIDv7 implementation #9

nurked opened this issue Aug 1, 2021 · 3 comments

Comments

@nurked
Copy link
Collaborator

nurked commented Aug 1, 2021

Current tests are very superficial

@igo95862
Copy link

Are there test vectors in the specification? (for example hashing algorithms specifications usually have them)

@nurked
Copy link
Collaborator Author

nurked commented Oct 28, 2021

Well, I was more alluding to the fact that my hash tests just test the fact that the function runs and do not check the resulted output.

@igo95862
Copy link

Since UUIDv7 is time based you could do a test there you first generate it, then decode it and then test if the input time is close to output.

However, I still think test vectors would be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants