Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swatinem/rust-cache is causing warnings in the CI #4154

Closed
tertsdiepraam opened this issue Nov 17, 2022 · 2 comments · Fixed by #4157
Closed

Swatinem/rust-cache is causing warnings in the CI #4154

tertsdiepraam opened this issue Nov 17, 2022 · 2 comments · Fixed by #4157

Comments

@tertsdiepraam
Copy link
Member

We see the following warning in the CI:

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

We already fixed the warnings in our own yaml files (#4098), but rust-cache is still generating some.

According to Swatinem/rust-cache#83, updating to v2 should fix the issue, but we need to check for breaking changes.

@tertsdiepraam
Copy link
Member Author

Oh this one might also be partially solved by this upgrade:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: Swatinem/rust-cache@v1, actions-rs/toolchain@v1

@miles170
Copy link
Contributor

miles170 commented Nov 18, 2022

I also found out that actions-rs/toolchain@v1 should come before Swatinem/rust-cache@v1 since rust-cache uses the rustc version as its cache key.

I can work on updating GitHub actions to run on Node 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants