Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API response container differs between ElasticSearch and Anserini APIs #97

Closed
davenquinn opened this issue Apr 6, 2020 · 0 comments
Closed

API response container differs between ElasticSearch and Anserini APIs #97

davenquinn opened this issue Apr 6, 2020 · 0 comments
Assignees
@iross
Labels
API Related to external interfaces with e.g. the COSMOS visualizer

Comments

@davenquinn
Copy link
Contributor

ElasticSearch uses results to wrap the list of returned objects, while Anserini uses objects. Right now, there is a switch in the frontend to fix this, but it is pretty brittle.

Proposed solution:

  • In API, standardize on objects as a list container
  • In frontend, try to find objects and fall back on results to keep current backends working.
@davenquinn davenquinn added the API Related to external interfaces with e.g. the COSMOS visualizer label Apr 6, 2020
davenquinn added a commit to UW-COSMOS/cosmos-visualizer that referenced this issue Apr 6, 2020
@davenquinn
Use fallback for API result unwrapping (anticipates fix to UW-COSMOS/…
25e9921 
…Cosmos#97)
davenquinn added a commit to UW-COSMOS/cosmos-visualizer that referenced this issue Apr 8, 2020
@davenquinn
Merge branch 'kb-viz-refactor'
f6db951 
* kb-viz-refactor:
  Added slider nullability
  Use Bibjson returned in initial API response
  Related terms links to API result (resolves #38)
  Small changes to related terms styles
  Fixed some aspects of related terms
  Use fallback for API result unwrapping (anticipates fix to UW-COSMOS/Cosmos#97)
  Updated loading state tracking (fixes #39)
  Vendorize image-sizing code (fixes #37)
  Switch OCR text links back to download disposition. Fixes #36
davenquinn added a commit to UW-COSMOS/cosmos-visualizer that referenced this issue Apr 9, 2020
@davenquinn
Removed switch to unwrap objects (responds to UW-COSMOS/Cosmos#97
7544f39
davenquinn added a commit to UW-COSMOS/cosmos-visualizer that referenced this issue Apr 9, 2020
@davenquinn
Merge branch 'kb-viz-refactor'
337ea55 
* kb-viz-refactor:
  Add subtle line around extractions (resolves #42)
  Updated scrolling to remove spurious API calls.
  Removed switch to unwrap objects (responds to UW-COSMOS/Cosmos#97
  Simplified extraction rendering (responds to UW-COSMOS/Cosmos#93)
  Removed console log
  Updated filtering (resolves #40 and #41)
  Add ability to set provide search backend in query string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iross iross

Labels
API Related to external interfaces with e.g. the COSMOS visualizer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iross @davenquinn