Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with GxE when using GenotypeIterator #26

Closed
jonaszierer opened this issue Jul 18, 2019 · 1 comment
Closed

Bug with GxE when using GenotypeIterator #26

jonaszierer opened this issue Jul 18, 2019 · 1 comment

Comments

@jonaszierer
Copy link

In assocTestSingle for GenotypeIterator it iterates over the SNP blocks. In each iteration GxE (the name of ithe interaction effects) is set to the model matrix.

if (!is.null(GxE)) GxE <- .modelMatrixColumns(null.model, GxE)

That works in the fist iteration when GxE is still a character but fails in the second iteration where GxE is already a model matrix. This should probably be moved outside the loop or changed to

if (!is.null(GxE)) GxE_m <- .modelMatrixColumns(null.model, GxE) 
assoc <- GENESIS:::testGenoSingleVar(null.model, G=geno, E=GxE_m, test=test)

(Though I can't really see a reson not to move it to before the start of the loop)

@smgogarten
Copy link
Collaborator

Thanks, fixed in 687ad1c and release v2.14.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants