Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix time zone for requests and reports #278

Merged
merged 2 commits into from
Feb 18, 2023
Merged

[Fix] Fix time zone for requests and reports #278

merged 2 commits into from
Feb 18, 2023

Conversation

leogjhuang
Copy link
Collaborator

@leogjhuang leogjhuang commented Feb 16, 2023 •
edited
Loading

Notion ticket link

Ticket

Implementation description

Add new formatter to display request and report dates in local time zone instead of UTC.

Notes

  • All formatted dates with an associated time (e.g., requests, reports) were replaced with the local formatter.
  • All formatted dates without an associated time (e.g., date of birth) were left untouched.

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@leogjhuang leogjhuang self-assigned this Feb 16, 2023
@leogjhuang leogjhuang marked this pull request as ready for review February 17, 2023 05:48
sherryhli
sherryhli approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leogjhuang leogjhuang merged commit 0e51e9a into staging Feb 18, 2023
@leogjhuang leogjhuang deleted the lh/requests-time-zone-bug branch February 18, 2023 00:56
leogjhuang added a commit that referenced this pull request Feb 19, 2023
@leogjhuang
[Fix] Fix time zone for requests and reports (#278)
f28abf6 
* [Fix] Fix time zone for requests and reports

* Add local time zone formatter function
@leogjhuang leogjhuang mentioned this pull request Feb 19, 2023
Merged
3 tasks
sherryhli pushed a commit that referenced this pull request Feb 20, 2023
@leogjhuang
[Fix] Fix time zone for requests and reports (#278) (#280)
61fe24b 
* [Fix] Fix time zone for requests and reports

* Add local time zone formatter function
leogjhuang added a commit that referenced this pull request Mar 20, 2023
@leogjhuang
[Release] Version 0.0.7
3f2d160 
* [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285)
* Update README (#284)
* Fix time zone bug in requests header (#281)
* [Fix] Fix time zone for requests and reports (#278)
* [Chore] Add BSF contributors to employee database (#277)
* [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276)
* [Docs] BSF CONTRIBUTING.md (#275)
leogjhuang added a commit that referenced this pull request Apr 29, 2023
@leogjhuang
[Release] Version 0.0.7
e73b435 
* [Fix] Change renewal report to most recent expiring permits (#293)
* [Feature] Allow processing fee field to be manually edited (#291)
* [Fix] Fix the GraphQL delete employee mutation (#286)
* [Fix] Add refunds to accountant report (#292)
* Add note field for permit holder’s old user ID (#290)
* Update User ID copy (#289)
* [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285)
* Update README (#284)
* Fix time zone bug in requests header (#281)
* [Fix] Fix time zone for requests and reports (#278)
* [Chore] Add BSF contributors to employee database (#277)
* [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276)
* [Docs] BSF CONTRIBUTING.md (#275)
@leogjhuang leogjhuang mentioned this pull request Apr 29, 2023
Merged
3 tasks
leogjhuang added a commit that referenced this pull request Apr 29, 2023
@leogjhuang
[Fix] Fix time zone for requests and reports (#278)
5fbc628 
* [Fix] Fix time zone for requests and reports

* Add local time zone formatter function
leogjhuang added a commit that referenced this pull request Apr 29, 2023
@leogjhuang @aaronabraham311
@OustanDing @sherryhli @ChinemeremChigbo
[Release] Version 0.0.7 (#294)
5fa19a8 
* [Release] Version 0.0.7

* [Fix] Change renewal report to most recent expiring permits (#293)
* [Feature] Allow processing fee field to be manually edited (#291)
* [Fix] Fix the GraphQL delete employee mutation (#286)
* [Fix] Add refunds to accountant report (#292)
* Add note field for permit holder’s old user ID (#290)
* Update User ID copy (#289)
* [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285)
* Update README (#284)
* Fix time zone bug in requests header (#281)
* [Fix] Fix time zone for requests and reports (#278)
* [Chore] Add BSF contributors to employee database (#277)
* [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276)
* [Docs] BSF CONTRIBUTING.md (#275)

* Revert "[Release] Version 0.0.7"

This reverts commit e73b435.

* [Docs] BSF CONTRIBUTING.md (#275)

* [Docs] Adding BSF CONTRIBUTING.md

* Small fixes to CONTRIBUTING.md

Co-authored-by: oustan10 <oustan10@gmail.com>

* [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276)

* [Chore] Add BSF contributors to employee database (#277)

* [Fix] Fix time zone for requests and reports (#278)

* [Fix] Fix time zone for requests and reports

* Add local time zone formatter function

* Fix time zone bug in requests header (#281)

* Update README (#284)

Update the readme with instructions for running the application locally
and seeding a self-hosted Postgres database.

* [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285)

* Update User ID copy (#289)

* Add note field for permit holder’s old user ID (#290)

* [Fix] Add refunds to accountant report (#292)

* Add refunds to accountant report

* Fix yarn lint commands

* Fix typing errors for resolver queries

* [Fix] Fix the GraphQL delete employee mutation (#286)

* [Feature] Allow processing fee field to be manually edited (#291)

* [Fix] Change renewal report to most recent expiring permits (#293)

---------

Co-authored-by: Aaron Abraham <aaronabraham311@gmail.com>
Co-authored-by: oustan10 <oustan10@gmail.com>
Co-authored-by: Sherry Li <sherryhli@users.noreply.github.com>
Co-authored-by: Chinemerem <chinemeremchigbo@Outlook.com>
leogjhuang added a commit that referenced this pull request Apr 29, 2023
@leogjhuang
[Release] Version 0.0.7 (#294)
723f256 
* [Fix] Change renewal report to most recent expiring permits (#293)
* [Feature] Allow processing fee field to be manually edited (#291)
* [Fix] Fix the GraphQL delete employee mutation (#286)
* [Fix] Add refunds to accountant report (#292)
* Add note field for permit holder’s old user ID (#290)
* Update User ID copy (#289)
* [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285)
* Update README (#284)
* Fix time zone bug in requests header (#281)
* [Fix] Fix time zone for requests and reports (#278)
* [Chore] Add BSF contributors to employee database (#277)
* [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276)
* [Docs] BSF CONTRIBUTING.md (#275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherryhli sherryhli sherryhli approved these changes

@ChinemeremChigbo ChinemeremChigbo Awaiting requested review from ChinemeremChigbo

@adilkap adilkap Awaiting requested review from adilkap

Assignees

@leogjhuang leogjhuang

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@leogjhuang @sherryhli