[Fix] Add refunds to accountant report #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherryhli
approved these changes
Apr 23, 2023
lib/reports/resolvers.ts
Outdated
| paymentMethod: true, | ||
| }, | ||
| }); | ||
| const methodPaymentRequest = JSON.parse(JSON.stringify(paymentRequest)); |
There was a problem hiding this comment.
-
I might be missing something but doesn't
JSON.parse(JSON.stringify(x))==x? Is the intention to make a deep copy, in which case I'd suggest defining adeepCopyfunction? -
Nit for naming
Suggested change
| const methodPaymentRequest = JSON.parse(JSON.stringify(paymentRequest)); | |
| const paymentGroupByMethodQuery = JSON.parse(JSON.stringify(paymentRequest)); |
sherryhli
reviewed
Apr 23, 2023
leogjhuang
added a commit
that referenced
this pull request
Apr 29, 2023
* [Fix] Change renewal report to most recent expiring permits (#293) * [Feature] Allow processing fee field to be manually edited (#291) * [Fix] Fix the GraphQL delete employee mutation (#286) * [Fix] Add refunds to accountant report (#292) * Add note field for permit holder’s old user ID (#290) * Update User ID copy (#289) * [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285) * Update README (#284) * Fix time zone bug in requests header (#281) * [Fix] Fix time zone for requests and reports (#278) * [Chore] Add BSF contributors to employee database (#277) * [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276) * [Docs] BSF CONTRIBUTING.md (#275)
leogjhuang
pushed a commit
that referenced
this pull request
Apr 29, 2023
* Add refunds to accountant report * Fix yarn lint commands * Fix typing errors for resolver queries
leogjhuang
added a commit
that referenced
this pull request
Apr 29, 2023
* [Release] Version 0.0.7 * [Fix] Change renewal report to most recent expiring permits (#293) * [Feature] Allow processing fee field to be manually edited (#291) * [Fix] Fix the GraphQL delete employee mutation (#286) * [Fix] Add refunds to accountant report (#292) * Add note field for permit holder’s old user ID (#290) * Update User ID copy (#289) * [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285) * Update README (#284) * Fix time zone bug in requests header (#281) * [Fix] Fix time zone for requests and reports (#278) * [Chore] Add BSF contributors to employee database (#277) * [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276) * [Docs] BSF CONTRIBUTING.md (#275) * Revert "[Release] Version 0.0.7" This reverts commit e73b435. * [Docs] BSF CONTRIBUTING.md (#275) * [Docs] Adding BSF CONTRIBUTING.md * Small fixes to CONTRIBUTING.md Co-authored-by: oustan10 <oustan10@gmail.com> * [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276) * [Chore] Add BSF contributors to employee database (#277) * [Fix] Fix time zone for requests and reports (#278) * [Fix] Fix time zone for requests and reports * Add local time zone formatter function * Fix time zone bug in requests header (#281) * Update README (#284) Update the readme with instructions for running the application locally and seeding a self-hosted Postgres database. * [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285) * Update User ID copy (#289) * Add note field for permit holder’s old user ID (#290) * [Fix] Add refunds to accountant report (#292) * Add refunds to accountant report * Fix yarn lint commands * Fix typing errors for resolver queries * [Fix] Fix the GraphQL delete employee mutation (#286) * [Feature] Allow processing fee field to be manually edited (#291) * [Fix] Change renewal report to most recent expiring permits (#293) --------- Co-authored-by: Aaron Abraham <aaronabraham311@gmail.com> Co-authored-by: oustan10 <oustan10@gmail.com> Co-authored-by: Sherry Li <sherryhli@users.noreply.github.com> Co-authored-by: Chinemerem <chinemeremchigbo@Outlook.com>
leogjhuang
added a commit
that referenced
this pull request
Apr 29, 2023
* [Fix] Change renewal report to most recent expiring permits (#293) * [Feature] Allow processing fee field to be manually edited (#291) * [Fix] Fix the GraphQL delete employee mutation (#286) * [Fix] Add refunds to accountant report (#292) * Add note field for permit holder’s old user ID (#290) * Update User ID copy (#289) * [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285) * Update README (#284) * Fix time zone bug in requests header (#281) * [Fix] Fix time zone for requests and reports (#278) * [Chore] Add BSF contributors to employee database (#277) * [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276) * [Docs] BSF CONTRIBUTING.md (#275)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
[5] Add refunds to accountant report
Implementation description
Notes
Checklist
[Feature],[Improvement]or[Fix],