Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the GraphQL delete employee mutation #286

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

leogjhuang
Copy link
Collaborator

Notion ticket link

Ticket

Implementation description

  • Fix input format in GQL delete employee mutation

Notes

  • N/A

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leogjhuang leogjhuang merged commit b3faebe into staging Apr 29, 2023
@leogjhuang leogjhuang deleted the lh/delete-employee-bug branch April 29, 2023 16:05
leogjhuang added a commit that referenced this pull request Apr 29, 2023
* [Fix] Change renewal report to most recent expiring permits (#293)
* [Feature] Allow processing fee field to be manually edited (#291)
* [Fix] Fix the GraphQL delete employee mutation (#286)
* [Fix] Add refunds to accountant report (#292)
* Add note field for permit holder’s old user ID (#290)
* Update User ID copy (#289)
* [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285)
* Update README (#284)
* Fix time zone bug in requests header (#281)
* [Fix] Fix time zone for requests and reports (#278)
* [Chore] Add BSF contributors to employee database (#277)
* [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276)
* [Docs] BSF CONTRIBUTING.md (#275)
@leogjhuang leogjhuang mentioned this pull request Apr 29, 2023
3 tasks
leogjhuang added a commit that referenced this pull request Apr 29, 2023
* [Release] Version 0.0.7

* [Fix] Change renewal report to most recent expiring permits (#293)
* [Feature] Allow processing fee field to be manually edited (#291)
* [Fix] Fix the GraphQL delete employee mutation (#286)
* [Fix] Add refunds to accountant report (#292)
* Add note field for permit holder’s old user ID (#290)
* Update User ID copy (#289)
* [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285)
* Update README (#284)
* Fix time zone bug in requests header (#281)
* [Fix] Fix time zone for requests and reports (#278)
* [Chore] Add BSF contributors to employee database (#277)
* [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276)
* [Docs] BSF CONTRIBUTING.md (#275)

* Revert "[Release] Version 0.0.7"

This reverts commit e73b435.

* [Docs] BSF CONTRIBUTING.md (#275)

* [Docs] Adding BSF CONTRIBUTING.md

* Small fixes to CONTRIBUTING.md

Co-authored-by: oustan10 <oustan10@gmail.com>

* [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276)

* [Chore] Add BSF contributors to employee database (#277)

* [Fix] Fix time zone for requests and reports (#278)

* [Fix] Fix time zone for requests and reports

* Add local time zone formatter function

* Fix time zone bug in requests header (#281)

* Update README (#284)

Update the readme with instructions for running the application locally
and seeding a self-hosted Postgres database.

* [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285)

* Update User ID copy (#289)

* Add note field for permit holder’s old user ID (#290)

* [Fix] Add refunds to accountant report (#292)

* Add refunds to accountant report

* Fix yarn lint commands

* Fix typing errors for resolver queries

* [Fix] Fix the GraphQL delete employee mutation (#286)

* [Feature] Allow processing fee field to be manually edited (#291)

* [Fix] Change renewal report to most recent expiring permits (#293)

---------

Co-authored-by: Aaron Abraham <aaronabraham311@gmail.com>
Co-authored-by: oustan10 <oustan10@gmail.com>
Co-authored-by: Sherry Li <sherryhli@users.noreply.github.com>
Co-authored-by: Chinemerem <chinemeremchigbo@Outlook.com>
leogjhuang added a commit that referenced this pull request Apr 29, 2023
* [Fix] Change renewal report to most recent expiring permits (#293)
* [Feature] Allow processing fee field to be manually edited (#291)
* [Fix] Fix the GraphQL delete employee mutation (#286)
* [Fix] Add refunds to accountant report (#292)
* Add note field for permit holder’s old user ID (#290)
* Update User ID copy (#289)
* [Fix] Pin GitHub CI runner image to ubuntu-20.04 (#285)
* Update README (#284)
* Fix time zone bug in requests header (#281)
* [Fix] Fix time zone for requests and reports (#278)
* [Chore] Add BSF contributors to employee database (#277)
* [Chore] Create docker-compose.yml file for local PostgreSQL instance (#276)
* [Docs] BSF CONTRIBUTING.md (#275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants