-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript Support #312
Comments
See #274 |
Yes, I would like to add types! I think my preferred route is not to port to TypeScript, but rather provide type files included along side the JavaScript source files. (Similar to how Observable Plot does this.) |
Can't wait for https://tc39.es/proposal-type-annotations/. 🙏 |
Yeah, makes sense. Can avoid/defer a rewrite/migration to TS. |
https://github.com/NiGhTTraX/ts-monorepo seems like a good solution to supporting typescript in a monorepo (without the need to rebuild everything to get the latest changes in downstream packages). |
#355 gets us pretty close so I'll close this for now. |
We still have a lot of places without types. |
I think an underrated reason to port to TypeScript is that it could make contributing back to Mosaic easier for the uninitiated like myself. Currently, reading the code involves jumping between a lot of files, and reasoning about how variables are mutated, wrapped, and unwrapped at different points. |
Any plans for adding types?
The text was updated successfully, but these errors were encountered: