Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript Support #312

Open
maneetgoyal opened this issue Mar 4, 2024 · 8 comments
Open

Add TypeScript Support #312

maneetgoyal opened this issue Mar 4, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@maneetgoyal
Copy link

Any plans for adding types?

@domoritz
Copy link
Member

domoritz commented Mar 4, 2024

See #274

@jheer
Copy link
Member

jheer commented Mar 4, 2024

Yes, I would like to add types! I think my preferred route is not to port to TypeScript, but rather provide type files included along side the JavaScript source files. (Similar to how Observable Plot does this.)

@jheer jheer added the enhancement New feature or request label Mar 4, 2024
@domoritz
Copy link
Member

domoritz commented Mar 4, 2024

Can't wait for https://tc39.es/proposal-type-annotations/. 🙏

@maneetgoyal
Copy link
Author

Yes, I would like to add types! I think my preferred route is not to port to TypeScript, but rather provide type files included along side the JavaScript source files. (Similar to how Observable Plot does this.)

Yeah, makes sense. Can avoid/defer a rewrite/migration to TS.

@domoritz
Copy link
Member

domoritz commented Apr 2, 2024

https://github.com/NiGhTTraX/ts-monorepo seems like a good solution to supporting typescript in a monorepo (without the need to rebuild everything to get the latest changes in downstream packages).

@domoritz
Copy link
Member

#355 gets us pretty close so I'll close this for now.

@domoritz domoritz reopened this May 25, 2024
@domoritz
Copy link
Member

We still have a lot of places without types.

@willium
Copy link
Member

willium commented Aug 15, 2024

I think an underrated reason to port to TypeScript is that it could make contributing back to Mosaic easier for the uninitiated like myself. Currently, reading the code involves jumping between a lot of files, and reasoning about how variables are mutated, wrapped, and unwrapped at different points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants