Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple files are under hard coded paths #36

Closed
jkudebeh opened this issue Aug 3, 2016 · 2 comments
Closed

multiple files are under hard coded paths #36

jkudebeh opened this issue Aug 3, 2016 · 2 comments

Comments

@jkudebeh
Copy link

jkudebeh commented Aug 3, 2016

I have installed the Boundless theme in /themes/uw-boundless and noticed some file not found messages in the console. See attached

$url = get_site_url() . "/wp-content/themes/uw-2014/assets/headers/suzzallo.jpg";

checking the WordPress API it looks like get_template_directory_uri() is the correct way to avoid using hard coded paths for images

https://developer.wordpress.org/reference/functions/get_template_directory_uri/
$url = get_template_directory_uri() . "/assets/headers/suzzallo.jpg";

The Quick Start guide doesn't say to use uw-2014 folder for the theme! You might consider updating the quick start to say the theme MUST be placed in the uw-2014 folder under wp-content/themes if the hard coded paths are not fixed

uw-sprite_error

@jvogtuw
Copy link

jvogtuw commented Dec 21, 2016

Not sure if this should be a separate issue, but relative paths in the .less files would be helpful as well. Most of them are, but there are a few (notably in uw.body-content.less) with absolute paths. Makes it frustrating when trying to keep the Drupal Boundless theme up to date with this one. Thanks!

@lcaple
Copy link
Contributor

lcaple commented Apr 10, 2018

Found the source of these errors in the less files referencing svg assets. They've been addressed in
925a67e
.

@lcaple lcaple closed this as completed Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants