Update proxy-container-installation-uyuni.adoc #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't mention how to create custom volume.
keichwa
requested changes
May 15, 2024
...llation-and-upgrade/pages/container-deployment/uyuni/proxy-container-installation-uyuni.adoc
Outdated
Show resolved
Hide resolved
...llation-and-upgrade/pages/container-deployment/uyuni/proxy-container-installation-uyuni.adoc
Outdated
Show resolved
Hide resolved
...llation-and-upgrade/pages/container-deployment/uyuni/proxy-container-installation-uyuni.adoc
Outdated
Show resolved
Hide resolved
…uni/proxy-container-installation-uyuni.adoc Co-authored-by: Karl Eichwalder <ke@suse.de>
…uni/proxy-container-installation-uyuni.adoc Co-authored-by: Karl Eichwalder <ke@suse.de>
…uni/proxy-container-installation-uyuni.adoc Co-authored-by: Karl Eichwalder <ke@suse.de>
keichwa
reviewed
May 16, 2024
...llation-and-upgrade/pages/container-deployment/uyuni/proxy-container-installation-uyuni.adoc
Outdated
Show resolved
Hide resolved
…uni/proxy-container-installation-uyuni.adoc
keichwa
requested changes
May 16, 2024
...llation-and-upgrade/pages/container-deployment/uyuni/proxy-container-installation-uyuni.adoc
Outdated
Show resolved
Hide resolved
...llation-and-upgrade/pages/container-deployment/uyuni/proxy-container-installation-uyuni.adoc
Outdated
Show resolved
Hide resolved
keichwa
approved these changes
May 16, 2024
mbussolotto
approved these changes
May 21, 2024
| @@ -135,6 +135,30 @@ The volumes are named: | |||
|
|
|||
| To override default volume settings, create the volumes prior to the first start of the pod using the [command]``podman volume create`` command. | |||
|
|
|||
| By default, the [package]``uyuni-proxy-systemd-services`` package creates these three directories that can be used to mount external disks: | |||
There was a problem hiding this comment.
uyuni-proxy-systemd-services it's going to be deprecated. Better say something mgrpxy for uyuni (instead for 4.3 uyuni-proxy-systemd-services is fine)
There was a problem hiding this comment.
Thanks for background info! In this case, I'll like to propose to merge it now as-is and backport it to SUMA 4.3. Then we can create a followup PR and change to mgrpxy for uyuni.
0rnela
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Update modules/installation-and-upgrade/pages/container-deployment/uyuni/proxy-container-installation-uyuni.adoc Co-authored-by: Karl Eichwalder <ke@suse.de> * Update modules/installation-and-upgrade/pages/container-deployment/uyuni/proxy-container-installation-uyuni.adoc * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't mention how to create custom volume.
Some hints
Consider adding an entry to the
CHANGELOG.mdfile in the toplevel directory.Cosmetic changes such as fixing typos do not need log entries (nevertheless it is important to fix typos, etc.)!
In the
manager-4.3, the hidden.changelogfile with a leading dot is still in use.Add Description, Target branches, and related Links below the following section titles.
In the Description, just enter a summary of why you created this PR (and, if available, add any relevant diagram).
Description
Short summary of why you created this PR (if you added documentation, please add any relevant diagram).
Target branches
ifevalstatements are needed to publish it for certain products only.Backport targets (edit as needed):
Links