Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerized commands centos (beta 2 review) #3025

Merged
merged 10 commits into from
May 27, 2024

Conversation

keichwa
Copy link
Contributor

@keichwa keichwa commented May 15, 2024

see https://github.com/SUSE/spacewalk/issues/24328

Some hints

Consider adding an entry to the CHANGELOG.md file in the toplevel directory.
Cosmetic changes such as fixing typos do not need log entries (nevertheless it is important to fix typos, etc.)!
In the manager-4.3, the hidden .changelog file with a leading dot is still in use.

Add Description, Target branches, and related Links below the following section titles.

In the Description, just enter a summary of why you created this PR (and, if available, add any relevant diagram).

Description

Short summary of why you created this PR (if you added documentation, please add any relevant diagram).

Target branches

  • Which product version this PR applies to (Uyuni, SUMA 4.3, SUMA MU X.Y.Z, or SUMA development version). This information can be helpful if ifeval statements are needed to publish it for certain products only.
  • Does this PR need to be backported? If yes, create an issue for tracking it and add the link to this PR.
  • Whenever possible, cross-reference each backport PR here, so that all backports can be easily accessed from the description.

Backport targets (edit as needed):

  • master
  • 4.3

Links

  • This PR tracks issue #<insert spacewalk issue, if any>
  • Related development PR #<insert PR link, if any>

Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this procedure could work. I think we need to pre-install perl-Text-Unidecode in server-image, then:
- mgrctl exec -- systemctl restart tomcat should be subtiture by mgradm restart
- /usr/local/bin/cent-errata.sh should be moved to a persisted location

@cbosdo @rjmateus JFYI, let me know if I missed anything

EDIT
Clarified by Cedric in below comments

Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big issue here is that the development tools module cannot be installed on SLE-Micro as it requires the base system module to be added... and this would turn a SLE Micro into a SLES.

Now we need to figure out what we want to tell the user to do... Should they run this script on a SLES machine (not the SUMA server thus) or should we provide an alternative using mgrctl?

@admd @rjmateus any opinion on that?

modules/client-configuration/pages/clients-centos.adoc Outdated Show resolved Hide resolved
@rjmateus
Copy link
Member

Outcome of the discussion/research: Keep it for uyuni and remove the all section for SUSE Manager.
@admd anything to adD?

@keichwa
Copy link
Contributor Author

keichwa commented May 21, 2024

Outcome of the discussion/research: Keep it for uyuni and remove the all section for SUSE Manager. @admd anything to adD?

Ok, done. Additionally, I changed the procedure suitable for a containerized Uyuni installation. I hope that's what we want and that I got it right. New reviews appreciated!

@keichwa keichwa requested review from cbosdo and rjmateus May 21, 2024 08:08
@admd
Copy link
Contributor

admd commented May 22, 2024

@keichwa these changes will not work!

This workaround to get the errata information was needed for centos, we only have CentOS 7 right now which is going EOL in June. So I would say keep the original text but only for Uyuni and maybe add a note in this section that this is only applicable to non-containerized Uyuni and this section will be removed after CentOS 7 will go EOL.

@keichwa keichwa marked this pull request as draft May 22, 2024 16:07
@keichwa keichwa marked this pull request as ready for review May 23, 2024 05:23
@keichwa
Copy link
Contributor Author

keichwa commented May 23, 2024

... So I would say keep the original text but only for Uyuni and maybe add a note in this section that this is only applicable to non-containerized Uyuni and this section will be removed after CentOS 7 will go EOL.

Thanks, makes a lot of sense. Done.

@keichwa keichwa merged commit 589ef27 into master May 27, 2024
1 check failed
@keichwa keichwa deleted the ccg-centos-review-#24328-keichwa branch May 27, 2024 13:25
0rnela pushed a commit that referenced this pull request Jun 3, 2024
* centos SUSE/spacewalk#24328
* separate host for script; uyuni only atm
* Added note about CentOS 7 errata checking script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants