-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uyuni proxy #10177 ke #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several changes requested. Also, please check if the procedures are working by using real instances (if not done already).
After reviewing the whole files, I really wonder if the differences are so big to justify different docs for Uyuni and SUSE Manager in this case. Not my call, but both having ifs and having separate files brings problems maintaining (one makes the doc somehow harder to read, the other forces to changes two files - adding the risk of people not remembering about one).
|
||
|
||
//// | ||
// REMARK: 2019-08-23, ke: this needs closer checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check this, as now we are duplicating the question for SUSE Manager 4.1 and Uyuni (and 4.0 if we port there)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you add the issue URL here.
Extract from my mails (per request): I'm still wondering how I can bootstrap an opensuse client where I can
install the proxy. I have these repos from
https://download.opensuse.org:
Leap_15-Uyuni-Client-Tools
leap15_1
leap15_1_update
proxy_uyuni4
I already created these channels:
leap 15.1 uyuni documentation 35157 0 0
leap 15.1 update uyuni documentation 7476 666 0
Leap_15-Uyuni-Client-Tools uyuni documentation 80 0 0
proxy uyuni4 uyuni documentation 84 0 0
zz my uyuni proxy4 leap151 uyuni documentation 42785 666 1
Now I first need a bootstrap repo and a recommendation how a should
arrange the channels for the proxy (base and child channels). And this one:
|
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Fine with me! And I'd especially like to continue with Uyuni docs and testing! Much more than re-organizing the Reference Guide ;)
Question is whether this applies for SUMA and Uyuni the same way. |
We don't have a problem with a lack of content in our books, adding new content is something that seems to have been happening quite effectively for many years. Unfortunately, sometimes you have to do the plumbing as well. I appreciate that reorganising guides is the most boring sort of docs plumbing, and we've done an awful lot of it over the past year. I promise that once the Ref Guide is done (in a couple of months, max), then we can get back to the more exciting stuff. See my email on 4.1 docs deliverables, there's a lot more exciting things coming down the pipeline for you to get stuck into.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
That's what I do when I contribute to the doc, doesn't matter if it's for SUSE Manager or Uyuni, and it's what I'd expect for any external contributor as well (not calling you external contributor :-)) FMPOV it's just a matter of good practice. In the same way a PR for the code project (uyuni-project/uyuni) should be tested and working, a PR for the doc should be tested and working. |
I am sorry to be so direct, but no approval from my side unless we have a final e2e test. If we are going to improve this, let's make sure that at least it works as it should. That doesn't mean this can't get merged, you go ahead but at your own risk :-) |
Julio González Gil <notifications@github.com> writes:
I am sorry to be so direct, but no approval from my side unless we have
a final e2e test.
Make perfect sense! I'm now about to verify it. The registration stage
still needs to be updated and committed. We just debugged it, but I
never actually committed it ;)
Next I'll not do such an exercise on my own; I'll ask for a demo first ;)
…--
Karl Eichwalder SUSE Software Solutions Germany GmbH
Product & Solution Documentation Maxfeldstraße 5
90409 Nürnberg, Germany
Geschäftsführer: Felix Imendörffer (HRB 36809, AG Nürnberg)
|
I do not know what "e2e" means. But I now was able to install, register, and set up an Uyuni Proxy. It's worth reading and approving, @juliogonzalez
@Loquacity I created a new file, but do not know where to include it in the configuration config nav file. It's |
Another question: Do we also want this in the 4.0 documentation? |
I meant I will try to review it today.
Not needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, but:
- Leap 15.0 is not supported as it's EoL
- Link the new opensuse client doc to the nav page.
- FMPOV we should only support salt for Uyuni Proxies (but @mcalmer and @paususe should agree as well)
- Remove all comments that are not strictly needed
- For things to be reviewed, add the URLs to the relevant issues.
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
close https://github.com/SUSE/spacewalk/issues/10177