Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uyuni proxy #10177 ke #45

Merged
merged 67 commits into from
Feb 27, 2020
Merged

Uyuni proxy #10177 ke #45

merged 67 commits into from
Feb 27, 2020

Conversation

keichwa
Copy link
Contributor

@keichwa keichwa commented Jan 8, 2020

Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes requested. Also, please check if the procedures are working by using real instances (if not done already).

After reviewing the whole files, I really wonder if the differences are so big to justify different docs for Uyuni and SUSE Manager in this case. Not my call, but both having ifs and having separate files brings problems maintaining (one makes the doc somehow harder to read, the other forces to changes two files - adding the risk of people not remembering about one).

modules/installation/pages/install-proxy-uyuni.adoc Outdated Show resolved Hide resolved
modules/installation/pages/install-proxy-uyuni.adoc Outdated Show resolved Hide resolved
modules/installation/pages/install-proxy-uyuni.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-registration.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved


////
// REMARK: 2019-08-23, ke: this needs closer checking
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check this, as now we are duplicating the question for SUSE Manager 4.1 and Uyuni (and 4.0 if we port there)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you add the issue URL here.

@keichwa
Copy link
Contributor Author

keichwa commented Jan 16, 2020

Extract from my mails (per request):

I'm still wondering how I can bootstrap an opensuse client where I can
install the proxy.  I have these repos from
https://download.opensuse.org:

Leap_15-Uyuni-Client-Tools
leap15_1
leap15_1_update
proxy_uyuni4


I already created these channels:

leap 15.1                      uyuni documentation     35157   0       0
leap 15.1 update               uyuni documentation     7476    666     0
Leap_15-Uyuni-Client-Tools     uyuni documentation     80      0       0
proxy uyuni4                   uyuni documentation     84      0       0
zz my uyuni proxy4 leap151     uyuni documentation     42785   666     1

Now I first need a bootstrap repo and a recommendation how a should
arrange the channels for the proxy (base and child channels).

And this one:


> This list is somehow confusing for me, can you provide the URLs of the 
> repositories assigned to the chanells?

https://download.opensuse.org/distribution/leap/15.1/repo/oss
https://download.opensuse.org/update/leap/15.1/oss/
https://download.opensuse.org/repositories/systemsmanagement:/Uyuni:/Master:/openSUSE_Leap_15-Uyuni-Client-Tools/openSUSE_Leap_15.0/

Instead of
https://download.opensuse.org/repositories/systemsmanagement:/Uyuni:/Stable/images/repo/Uyuni-Proxy-4.0-POOL-x86_64-Media1/
I shall probably use Master here too.

> How did you add the channels? Via spacewalk-common-channels?

With the Web UI (Software > Manage > Channels).  You can access it here:
https://d137.suse.de/ — the VM is running on my workstation.

I tried spacewalk-common-channels, but it did not like me.

modules/installation/pages/install-proxy-uyuni.adoc Outdated Show resolved Hide resolved
modules/installation/pages/install-proxy-uyuni.adoc Outdated Show resolved Hide resolved
modules/installation/pages/install-proxy-uyuni.adoc Outdated Show resolved Hide resolved
modules/installation/pages/install-proxy-uyuni.adoc Outdated Show resolved Hide resolved
modules/installation/pages/install-proxy-uyuni.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
@juliogonzalez
Copy link
Member

What I got from @paususe is that whoever is documenting, should test if the changes are correct (in short: verify that the procedure works as described), specially when something is new or for big rewrites.

@paususe am I missing anything?

@keichwa
Copy link
Contributor Author

keichwa commented Feb 20, 2020

What I got from @paususe is that whoever is documenting, should test if the changes are correct (in short: verify that the procedure works as described), specially when something is new or for big rewrites.

Fine with me! And I'd especially like to continue with Uyuni docs and testing! Much more than re-organizing the Reference Guide ;)

@paususe am I missing anything?

Question is whether this applies for SUMA and Uyuni the same way.

@Loquacity
Copy link
Contributor

What I got from @paususe is that whoever is documenting, should test if the changes are correct (in short: verify that the procedure works as described), specially when something is new or for big rewrites.

Fine with me! And I'd especially like to continue with Uyuni docs and testing! Much more than re-organizing the Reference Guide ;)

We don't have a problem with a lack of content in our books, adding new content is something that seems to have been happening quite effectively for many years. Unfortunately, sometimes you have to do the plumbing as well. I appreciate that reorganising guides is the most boring sort of docs plumbing, and we've done an awful lot of it over the past year. I promise that once the Ref Guide is done (in a couple of months, max), then we can get back to the more exciting stuff. See my email on 4.1 docs deliverables, there's a lot more exciting things coming down the pipeline for you to get stuck into.

@paususe am I missing anything?

Question is whether this applies for SUMA and Uyuni the same way.

Copy link
Contributor

@jcayouette jcayouette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juliogonzalez
Copy link
Member

Question is whether this applies for SUMA and Uyuni the same way.

That's what I do when I contribute to the doc, doesn't matter if it's for SUSE Manager or Uyuni, and it's what I'd expect for any external contributor as well (not calling you external contributor :-))

FMPOV it's just a matter of good practice. In the same way a PR for the code project (uyuni-project/uyuni) should be tested and working, a PR for the doc should be tested and working.

@juliogonzalez
Copy link
Member

I am sorry to be so direct, but no approval from my side unless we have a final e2e test.

If we are going to improve this, let's make sure that at least it works as it should.

That doesn't mean this can't get merged, you go ahead but at your own risk :-)

@keichwa
Copy link
Contributor Author

keichwa commented Feb 24, 2020 via email

@keichwa
Copy link
Contributor Author

keichwa commented Feb 25, 2020

I am sorry to be so direct, but no approval from my side unless we have a final e2e test.

If we are going to improve this, let's make sure that at least it works as it should.

I do not know what "e2e" means. But I now was able to install, register, and set up an Uyuni Proxy. It's worth reading and approving, @juliogonzalez

That doesn't mean this can't get merged, you go ahead but at your own risk :-)
Now I can happily take the risk. My description is not a smooth reading (becaus of the xrefs), but now it work.

@Loquacity I created a new file, but do not know where to include it in the configuration config nav file. It's client-configuration/pages/clients-opensuse.adoc. I need your help, please.

@keichwa
Copy link
Contributor Author

keichwa commented Feb 25, 2020

Another question: Do we also want this in the 4.0 documentation?

@juliogonzalez
Copy link
Member

I do not know what "e2e" means. But I now was able to install, register, and set up an Uyuni Proxy. It's worth reading and approving, @juliogonzalez

I meant End-to-End testing, which is what you did (testing that it works as in a production environment).

I will try to review it today.

Another question: Do we also want this in the 4.0 documentation?

Not needed.

Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, but:

  • Leap 15.0 is not supported as it's EoL
  • Link the new opensuse client doc to the nav page.
  • FMPOV we should only support salt for Uyuni Proxies (but @mcalmer and @paususe should agree as well)
  • Remove all comments that are not strictly needed
  • For things to be reviewed, add the URLs to the relevant issues.

modules/client-configuration/pages/clients-opensuse.adoc Outdated Show resolved Hide resolved
modules/client-configuration/pages/clients-opensuse.adoc Outdated Show resolved Hide resolved
modules/client-configuration/pages/clients-opensuse.adoc Outdated Show resolved Hide resolved
modules/client-configuration/pages/clients-opensuse.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-registration.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-registration.adoc Outdated Show resolved Hide resolved
@keichwa keichwa merged commit 8bc8285 into master Feb 27, 2020
@Loquacity Loquacity deleted the uyuni-proxy-#10177-ke branch September 14, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants