-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retail use productname #12185 keichwa #487
Conversation
I especially would like to know whether the redefinition of the 'smr' macro in entities.adoc with 'productname' would work? |
|
||
=== UEFI Secure Booting Requirements | ||
|
||
// Shall we also mention Leap? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How binding word supported
is here in docs? For SLE it is easy, as we provide support for SLE. But for Leap and Uyuni it is different picture.
UEFI Secure Boot should work on Leap, but I'm not sure about the supported statement.
Ondřej Holeček <notifications@github.com> writes:
How binding word supported is here in docs? For SLE it is easy, as we
provide support for SLE. But for Leap and Uyuni it is different
picture.
Nice spot, a can of worms. I'll probably ifdef'ing it.
UEFI Secure Boot should work on Leap, but I'm not sure about the
supported statement.
Thanks for feedback!
…--
Karl Eichwalder
|
disable UEFI statement on uyuni
Done. I also changed the support statement with the x86_64 architecture. For uyuni I now say, it is tested on that arch. @aaannz if we should say something better please provide feedback! @Loquacity what do you think? |
Co-authored-by: Lana Brindley <lbrindley@suse.de>
Co-authored-by: Lana Brindley <lbrindley@suse.de>
Just noticed this question. I think we would need to define {smr} as "for Retail" and use it as {productname} {smr}. |
Lana Brindley <notifications@github.com> writes:
Just noticed this question. I think we would need to define {smr} as "for Retail" and use it as {productname} {smr}.
Yes, this would work. Thanks!
…--
Karl Eichwalder
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check the built docs?
I now checked uyuni and suma. It builds. I think we should now merge (if you do not see big obstacles) and improve the rest later. |
Yep, let's get it in before 4.1.2 👍 |
Thus far, I did not intent to back-port it to 4.1, but it would make sense. |
I haven't cut the branch yet. If you want it in, you will need to merge it today. |
For 4.1, I had to create a new PR: #533 |
Description
For product names make use of macros. the 'susemgr' does not make sense in the uyuni context.
Done for the first sections. I'll start a new PR for the rest.
Target branches
Which product version does this PR apply to?
Links
It partially addresses https://github.com/SUSE/spacewalk/issues/12185