Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retail use productname #12185 keichwa #487

Merged
merged 16 commits into from
Sep 14, 2020

Conversation

keichwa
Copy link
Contributor

@keichwa keichwa commented Aug 27, 2020

Description

For product names make use of macros. the 'susemgr' does not make sense in the uyuni context.
Done for the first sections. I'll start a new PR for the rest.

Target branches

Which product version does this PR apply to?

  • Manager-4.0
  • Manager-4.1
  • Manager-4.2
  • Uyuni

Links

It partially addresses https://github.com/SUSE/spacewalk/issues/12185

@keichwa
Copy link
Contributor Author

keichwa commented Aug 27, 2020

I especially would like to know whether the redefinition of the 'smr' macro in entities.adoc with 'productname' would work?


=== UEFI Secure Booting Requirements

// Shall we also mention Leap?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How binding word supported is here in docs? For SLE it is easy, as we provide support for SLE. But for Leap and Uyuni it is different picture.
UEFI Secure Boot should work on Leap, but I'm not sure about the supported statement.

@keichwa
Copy link
Contributor Author

keichwa commented Aug 27, 2020 via email

@keichwa
Copy link
Contributor Author

keichwa commented Aug 27, 2020

Done. I also changed the support statement with the x86_64 architecture. For uyuni I now say, it is tested on that arch. @aaannz if we should say something better please provide feedback!

@Loquacity what do you think?

modules/retail/pages/retail-network-arch.adoc Show resolved Hide resolved
modules/retail/pages/retail-requirements.adoc Outdated Show resolved Hide resolved
modules/retail/pages/retail-requirements.adoc Outdated Show resolved Hide resolved
keichwa and others added 3 commits August 28, 2020 07:00
Co-authored-by: Lana Brindley <lbrindley@suse.de>
Co-authored-by: Lana Brindley <lbrindley@suse.de>
@keichwa keichwa requested a review from Loquacity August 28, 2020 05:10
@Loquacity
Copy link
Contributor

I especially would like to know whether the redefinition of the 'smr' macro in entities.adoc with 'productname' would work?

Just noticed this question. I think we would need to define {smr} as "for Retail" and use it as {productname} {smr}.

@keichwa
Copy link
Contributor Author

keichwa commented Sep 7, 2020 via email

Copy link
Contributor

@Loquacity Loquacity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check the built docs?

@keichwa
Copy link
Contributor Author

keichwa commented Sep 10, 2020

Did you check the built docs?

I now checked uyuni and suma. It builds. I think we should now merge (if you do not see big obstacles) and improve the rest later.

@Loquacity
Copy link
Contributor

Yep, let's get it in before 4.1.2 👍

@keichwa
Copy link
Contributor Author

keichwa commented Sep 14, 2020

Yep, let's get it in before 4.1.2 +1

Thus far, I did not intent to back-port it to 4.1, but it would make sense.

@Loquacity
Copy link
Contributor

Yep, let's get it in before 4.1.2 +1

Thus far, I did not intent to back-port it to 4.1, but it would make sense.

I haven't cut the branch yet. If you want it in, you will need to merge it today.

@keichwa keichwa merged commit 3d10df1 into master Sep 14, 2020
@keichwa keichwa deleted the retail-use-productname-#12185-keichwa branch September 14, 2020 04:39
keichwa added a commit that referenced this pull request Sep 14, 2020
@keichwa
Copy link
Contributor Author

keichwa commented Sep 14, 2020

Yep, let's get it in before 4.1.2 +1

Thus far, I did not intent to back-port it to 4.1, but it would make sense.

I haven't cut the branch yet. If you want it in, you will need to merge it today.

For 4.1, I had to create a new PR: #533
cherry-pick did not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants