fix low contrast in homepage

[Rakielle]

What does this PR change?

This PR fixes the low contrast between the menu items and the background color, as identified by WAVE

GUI diff

Before:

After:

• DONE

Documentation

• No documentation needed: This changes improves the contrast color of the texts and the background to enhance accessibility, no additional documentation is needed.

• DONE

Test coverage

• No tests: already covered

• DONE

Links

Fixes #7101

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

[Etheryte]

While this fixes the contrast issue, I think it creates another new problem we don't want to have, which is that we now have a new color we only use in one place. Given that it's right next to the old color used in the home icon, I think we might have some better options here.

What about using the same menu highlighting logic as the Suma theme uses? Over time we're aiming to bring the two themes closer together anyway and this way we can solve both the contrast issue as well as keep the color. What do you think @Rakielle @cbbayburt?

For context, this is how the highlighting is handled in the Suma theme:

[cbbayburt]

What about using the same menu highlighting logic as the Suma theme uses? Over time we're aiming to bring the two themes closer together anyway and this way we can solve both the contrast issue as well as keep the color. What do you think @Rakielle @cbbayburt?

I think it's a good idea. @Etheryte could you point out where this SUMA style menu highlighting is implemented?

[Etheryte]

If I'm not mistaken that part should come from the old theme base in web/html/src/branding/css/base/theme.less, grep for @aside-menu-active. You will probably need other changes too aside from setting just that bit though, since I'd wager the underlying styles are different.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR was closed because it has been stalled for 10 days with no activity.

[Etheryte]

I've manually cherry-picked the changes from this PR into #8420 and #8169 so this should be safe to close. Since the underlying structure changed a fair bit the change set doesn't apply cleanly directly, but the contrast should now be fine.