-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu 24.04 #8504
base: master
Are you sure you want to change the base?
Add Ubuntu 24.04 #8504
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mayrstefan. Thant you, for your contribution!
Please also add the new Ubuntu 24.04 channels to the TIMEOUT_BY_CHANNEL_NAME
array in constants.rb
. Regarding the values, you can take a look at the ones from Ubuntu 22.04. They are all estimates.
testsuite/features/build_validation/init_clients/ubuntu2404_minion.feature
Outdated
Show resolved
Hide resolved
testsuite/features/build_validation/init_clients/ubuntu2404_ssh_minion.feature
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a QE/test suite perspective, the changes LGTM. Thank you for your contribution!
Add PR for documentation: uyuni-project/uyuni-docs#2918 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there is one typo I assume.
susemanager-utils/testing/automation/update-obs-environment-cr-project.sh
Outdated
Show resolved
Hide resolved
#8503 is related to prepare Uyuni for the next Ubuntu release. |
What is needed to get this PR get merged? Is there a chance to get this into 2024.06? |
Hi Stefan, let me check this internally. So far I could check that repos seem to mirror correctly. I could not test a bootstrap yet because the venv-salt-minion package is not available yet. I will follow up with this. |
We're aiming to give support to Ubuntu 2024.04 in Uyuni release 2024.07 (although not guaranteed, could be that it arrives later). Of course, if this is possible before, we will not delay it on purpose, in case the enablement is ready. |
I have removed "merge-candidate" label as only the testsuite part was reviewed yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayrstefan thank you for the contribution. As some things have changed in 24.04 like this https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890#deb822-sources-management , can you please verify if what we you have in this PR suffices.
@@ -0,0 +1 @@ | |||
- Enable basic support for Ubuntu 24.04 LTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayrstefan I don't see any changes in susemanager-sls package so this is not needed.
This is addressed in PR #8503 which should also work for the next Debian release. That's why this is in a separate PR. |
I was trying to test this PR, so far the reposync seems to have worked. However, the bootstrap repo was not generated, and bootstrapping obviously fails. When running
I've built the packages from this PR and pushed them to my OBS repo, see: I reverted the packages to the Uyuni ones, and when doing a diff of the Does this make sense for you? |
Co-authored-by: Dominik Gedon <dominik.gedon@suse.com>
Co-authored-by: Ondřej Holeček <oholecek@aaannz.eu>
What does this PR change?
This is some basic preparation to support Ubuntu 24.04 LTS which will be released next month
GUI diff
No difference.
Documentation
(OPTIONAL) Documentation PR: will be added when Ubuntu 24.04 has been officially released. This PR just prepares Uyuni for it
DONE
Test coverage
Unit tests were added
Cucumber tests were added
DONE
Links
Issue(s): #8448
Changelogs
Changelogs were added to the commits
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!