Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 24.04 #8504

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

mayrstefan
Copy link
Contributor

@mayrstefan mayrstefan commented Mar 23, 2024

What does this PR change?

This is some basic preparation to support Ubuntu 24.04 LTS which will be released next month

GUI diff

No difference.

  • DONE

Documentation

  • (OPTIONAL) Documentation PR: will be added when Ubuntu 24.04 has been officially released. This PR just prepares Uyuni for it

  • DONE

Test coverage

  • Unit tests were added

  • Cucumber tests were added

  • DONE

Links

Issue(s): #8448

  • DONE

Changelogs

Changelogs were added to the commits

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@mayrstefan mayrstefan requested review from a team as code owners March 23, 2024 13:39
@mayrstefan mayrstefan requested a review from aaannz March 23, 2024 13:39
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8504/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8504/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

Suggested tests to cover this Pull Request
  • sle_ssh_minion
  • min_salt_migration
  • min_salt_install_with_staging
  • proxy_register_as_minion_with_script
  • min_deblike_salt
  • allcli_overview_systems_details
  • min_salt_formulas
  • min_project_lotus
  • srv_docker_cve_audit
  • minssh_move_from_and_to_proxy
  • min_salt_install_package
  • min_deblike_remote_command
  • srv_monitoring
  • srv_datepicker
  • min_salt_openscap_audit
  • minkvm_guests
  • min_monitoring
  • min_recurring_action
  • min_salt_minion_details
  • srv_restart
  • min_rhlike_openscap_audit
  • srv_distro_cobbler
  • srv_custom_system_info
  • min_salt_minions_page
  • min_deblike_salt_install_package
  • min_empty_system_profiles
  • min_cve_id_new_syntax
  • min_ssh_tunnel
  • allcli_sanity
  • min_move_from_and_to_proxy
  • min_ansible_control_node
  • srv_power_management_redfish
  • min_bootstrap_script
  • min_rhlike_monitoring
  • srv_menu
  • allcli_software_channels_dependencies
  • min_cve_audit
  • min_salt_mgrcompat_state
  • min_config_state_channel
  • srv_reportdb
  • buildhost_bootstrap
  • minssh_salt_install_package
  • allcli_reboot
  • minssh_bootstrap_api
  • proxy_retail_pxeboot_and_mass_import
  • min_rhlike_salt_install_package_and_patch
  • min_deblike_monitoring
  • min_deblike_salt_install_with_staging
  • min_check_patches_install
  • srv_user_configuration_salt_states
  • srv_scc_user_credentials
  • srv_cobbler_distro
  • min_rhlike_salt
  • min_salt_lock_packages
  • srv_rename_hostname
  • proxy_branch_network
  • min_bootstrap_api
  • srv_group_union_intersection
  • minssh_ansible_control_node
  • srv_virtual_host_manager
  • allcli_action_chain
  • min_salt_formulas_advanced
  • min_config_state_channel_api
  • srv_cobbler_profile
  • srv_power_management
  • min_salt_user_states
  • allcli_config_channel
  • min_virthost
  • min_deblike_openscap_audit
  • srv_power_management_api
  • min_action_chain
  • min_config_state_channel_subscriptions
  • buildhost_docker_auth_registry
  • min_timezone
  • min_bootstrap_negative
  • buildhost_osimage_build_image
  • srv_manage_activationkey
  • srv_advanced_search
  • min_activationkey
  • allcli_software_channels
  • min_bootstrap_reactivation
  • min_rhlike_remote_command
  • srv_maintenance_windows
  • min_salt_pkgset_beacon
  • proxy_as_pod_basic_tests
  • buildhost_docker_build_image
  • sle_minion
  • min_deblike_ssh
  • min_salt_software_states
  • min_rhlike_ssh
  • minssh_action_chain
  • min_custom_pkg_download_endpoint
  • allcli_system_group
  • proxy_cobbler_pxeboot
  • srv_manage_channels_page
  • min_bootstrap_ssh_key
  • min_retracted_patches
  • min_change_software_channel

Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mayrstefan. Thant you, for your contribution!
Please also add the new Ubuntu 24.04 channels to the TIMEOUT_BY_CHANNEL_NAME array in constants.rb. Regarding the values, you can take a look at the ones from Ubuntu 22.04. They are all estimates.

nodeg
nodeg previously approved these changes Mar 26, 2024
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a QE/test suite perspective, the changes LGTM. Thank you for your contribution!

@mayrstefan
Copy link
Contributor Author

Add PR for documentation: uyuni-project/uyuni-docs#2918

aaannz
aaannz previously approved these changes Apr 9, 2024
Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is one typo I assume.

@mayrstefan
Copy link
Contributor Author

#8503 is related to prepare Uyuni for the next Ubuntu release.

@mayrstefan
Copy link
Contributor Author

What is needed to get this PR get merged? Is there a chance to get this into 2024.06?

@raulillo82
Copy link
Contributor

What is needed to get this PR get merged? Is there a chance to get this into 2024.06?

Hi Stefan, let me check this internally. So far I could check that repos seem to mirror correctly. I could not test a bootstrap yet because the venv-salt-minion package is not available yet. I will follow up with this.
I'm not sure about 2024.06 (can't even confirm whether there will be a release next month). General time frame for Ubuntu 24.04 was "Summer". I'll try to get back to you with something more accurate within the week.

@raulillo82
Copy link
Contributor

We're aiming to give support to Ubuntu 2024.04 in Uyuni release 2024.07 (although not guaranteed, could be that it arrives later). Of course, if this is possible before, we will not delay it on purpose, in case the enablement is ready.

@juliogonzalez juliogonzalez added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Jun 6, 2024
@mayrstefan mayrstefan dismissed stale reviews from aaannz and nodeg via 014d9be June 6, 2024 13:32
@raulillo82 raulillo82 requested a review from aaannz June 20, 2024 08:26
@raulillo82 raulillo82 requested a review from nodeg June 20, 2024 08:26
nodeg
nodeg previously approved these changes Jun 21, 2024
@mcalmer mcalmer removed the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Jun 21, 2024
@mcalmer
Copy link
Contributor

mcalmer commented Jun 21, 2024

I have removed "merge-candidate" label as only the testsuite part was reviewed yet.

@raulillo82 raulillo82 requested a review from mcalmer June 24, 2024 07:21
Copy link
Contributor

@admd admd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayrstefan thank you for the contribution. As some things have changed in 24.04 like this https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890#deb822-sources-management , can you please verify if what we you have in this PR suffices.

@@ -0,0 +1 @@
- Enable basic support for Ubuntu 24.04 LTS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayrstefan I don't see any changes in susemanager-sls package so this is not needed.

@mayrstefan
Copy link
Contributor Author

@mayrstefan thank you for the contribution. As some things have changed in 24.04 like this https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890#deb822-sources-management , can you please verify if what we you have in this PR suffices.

This is addressed in PR #8503 which should also work for the next Debian release. That's why this is in a separate PR.

@raulillo82
Copy link
Contributor

raulillo82 commented Jun 25, 2024

I was trying to test this PR, so far the reposync seems to have worked.

However, the bootstrap repo was not generated, and bootstrapping obviously fails. When running mgr-create-bootstrap-repo manually, I'm getting this error:

Traceback (most recent call last):
  File "/usr/sbin/mgr-create-bootstrap-repo", line 17, in <module>
    from uyuni.common import usix, rhnLib, notificationUtils
ImportError: cannot import name 'notificationUtils'

I've built the packages from this PR and pushed them to my OBS repo, see:
https://download.opensuse.org/repositories/home:/raulosuna:/branches:/systemsmanagement:/Uyuni:/Master/openSUSE_Leap_15.5/

I reverted the packages to the Uyuni ones, and when doing a diff of the mgr-create-bootstrap-repo script, I saw a lot of lines changing. So my theory is that as this PR was submitted very long ago, and there have been Uyuni versions bumps in the middle, there might be a rebase needed.

Does this make sense for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants