Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 24.04 LTS #2918

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mayrstefan
Copy link
Contributor

@mayrstefan mayrstefan commented Apr 7, 2024

Description

Add Ubuntu 24.04 LTS when it is released an the PR for Uyuni is merged

Target branches

  • Which product version this PR applies to: Uyuni
  • Does this PR need to be backported? I guess this will also be in SUMA

Backport targets (edit as needed):

  • master
  • 4.3

Links

@0rnela
Copy link
Contributor

0rnela commented Apr 23, 2024

Thank you @mayrstefan. We are creating the formal issues for adding the client to the documentation before approving and merging the PR.

@0rnela 0rnela added the zFeature not ready Feature is not ready to be documented. When ready add issue to "docs backlog" label May 8, 2024
Copy link
Contributor

@raulillo82 raulillo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my two comments regarding merging conflicts, it looks good to me. However I will need an extra review from Docs team, I'll reach them today meanwhile.
In the meantime, @mayrstefan , can you maybe rebase this again? Probably the merging conflicts will disappear them (or you can easily solve them). Thanks a lot in advance for the contribution, I'm pushing to include this (and the main PR together with this).

* Packages and metadata are provided by Ubuntu, not by {suse}
* For supported products, see the support table and the release notes
====
endif::[]

ifeval::[{suma-content} == true]
{productname} supports {ubuntu} 20.04 LTS and 22.04 LTS clients using {salt}.
{productname} supports {ubuntu} 20.04 LTS, 22.04 LTS and 24.04 LTS clients using {salt}.
//For information about registering Salt clients running {ubuntu} 18.04 LTS, see xref:client-configuration:clients-ubuntu-old.adoc[].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//For information about registering Salt clients running {ubuntu} 18.04 LTS, see xref:client-configuration:clients-ubuntu-old.adoc[].

This comment line seems not to exist any more in master. So probably when you rebase, the conflict disappears.


| Recurring Actions
| {check}
| {check}
| {salt}
| {salt}
| {check}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conflict here right now, which should disappear when you rebase on top of the latest master, if I'm not mistaken. These | {salt} lines are not there any more right now.

@keichwa
Copy link
Contributor

keichwa commented Jun 20, 2024

Other than my two comments regarding merging conflicts, it looks good to me. However I will need an extra review from Docs team, I'll reach them today meanwhile. In the meantime, @mayrstefan , can you maybe rebase this again? Probably the merging conflicts will disappear them (or you can easily solve them). Thanks a lot in advance for the contribution, I'm pushing to include this (and the main PR together with this).

Yes, to me it also looks good. It looks as if you could also the github UI (webeditor) to solve the conflicts.

Copy link
Contributor

@jcayouette jcayouette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please backport to manager-5.0 (Or we can).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zFeature not ready Feature is not ready to be documented. When ready add issue to "docs backlog"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants