-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu 24.04 LTS #2918
base: master
Are you sure you want to change the base?
Add Ubuntu 24.04 LTS #2918
Conversation
Thank you @mayrstefan. We are creating the formal issues for adding the client to the documentation before approving and merging the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my two comments regarding merging conflicts, it looks good to me. However I will need an extra review from Docs team, I'll reach them today meanwhile.
In the meantime, @mayrstefan , can you maybe rebase this again? Probably the merging conflicts will disappear them (or you can easily solve them). Thanks a lot in advance for the contribution, I'm pushing to include this (and the main PR together with this).
* Packages and metadata are provided by Ubuntu, not by {suse} | ||
* For supported products, see the support table and the release notes | ||
==== | ||
endif::[] | ||
|
||
ifeval::[{suma-content} == true] | ||
{productname} supports {ubuntu} 20.04 LTS and 22.04 LTS clients using {salt}. | ||
{productname} supports {ubuntu} 20.04 LTS, 22.04 LTS and 24.04 LTS clients using {salt}. | ||
//For information about registering Salt clients running {ubuntu} 18.04 LTS, see xref:client-configuration:clients-ubuntu-old.adoc[]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//For information about registering Salt clients running {ubuntu} 18.04 LTS, see xref:client-configuration:clients-ubuntu-old.adoc[]. |
This comment line seems not to exist any more in master. So probably when you rebase, the conflict disappears.
|
||
| Recurring Actions | ||
| {check} | ||
| {check} | ||
| {salt} | ||
| {salt} | ||
| {check} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a conflict here right now, which should disappear when you rebase on top of the latest master, if I'm not mistaken. These | {salt}
lines are not there any more right now.
Yes, to me it also looks good. It looks as if you could also the github UI (webeditor) to solve the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please backport to manager-5.0 (Or we can).
Description
Add Ubuntu 24.04 LTS when it is released an the PR for Uyuni is merged
Target branches
Backport targets (edit as needed):
Links