Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel selection using SSM #9017

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

parlt91
Copy link
Contributor

@parlt91 parlt91 commented Jul 8, 2024

What does this PR change?

Port of https://github.com/SUSE/spacewalk/pull/24746

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Signed-off-by: Pascal Arlt <parlt@suse.com>
@parlt91 parlt91 requested a review from a team as a code owner July 8, 2024 13:17
Copy link
Contributor

github-actions bot commented Jul 8, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9017/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9017/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Member

@Etheryte Etheryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, yeah this is my bad really. I noticed this bug when migrating the code to Typescript, but I guess I didn't have the capacity to come back and test this in the midst of the rest of it.

Thanks for fixing this. 🙂

@Etheryte
Copy link
Member

Etheryte commented Jul 8, 2024

Oh never mind, I actually did write this down as a ticket. I guess this PR closes https://github.com/SUSE/spacewalk/issues/14265 then?

@parlt91
Copy link
Contributor Author

parlt91 commented Jul 9, 2024

Oh never mind, I actually did write this down as a ticket. I guess this PR closes SUSE/spacewalk#14265 then?

Looks like you're right :)

@admd admd merged commit 34091b0 into uyuni-project:master Jul 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants