Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page transition not possible on 2.4.5.1.1.2 #37

Closed
martindusinberre opened this issue Aug 22, 2019 · 7 comments
Closed

Page transition not possible on 2.4.5.1.1.2 #37

martindusinberre opened this issue Aug 22, 2019 · 7 comments
Assignees
Labels
bug Something isn't working high high priority

Comments

@martindusinberre
Copy link
Collaborator

This happened to me in my testing on Friday at 2.4.5.1.1.2, and it happened to a player on Monday also on the same page (2.4.5.1.1.2): the "continue" button becomes invisible on this page, and there's no way to continue the game (going back to ".../games" and then clicking on "Continue" for existing games doesn't work).

@martindusinberre martindusinberre added bug Something isn't working high high priority labels Aug 22, 2019
@christian-bernet
Copy link
Contributor

christian-bernet commented Aug 28, 2019

estimate: 2 hours

@christian-bernet
Copy link
Contributor

christian-bernet commented Sep 9, 2019

related to #46

When the backend is slow and I click multiple times on a page transition button, it results in multiple backend calls, which is bad.

@christian-bernet christian-bernet self-assigned this Sep 18, 2019
@christian-bernet
Copy link
Contributor

This should be not possible any more, because of the changes of #46

@martindusinberre
Copy link
Collaborator Author

I'll close this because we are testing #46

@yaslena
Copy link
Collaborator

yaslena commented Sep 30, 2019

This still does not work. I can not trasition off this page. It only affects page transitions from HSA, when you visit it on day 5 so I compared the json here with the other HSA pages. It seems that there is a little mistake in the transition json on that page:
{ "id": null, "from": null, "to": "chapter4/2.4.5.1.1.3/page.json", "buttonText": "Continue", "time": { "time": 0 }, "money": { "amount": 0 }, "criteria": [ { "pageCriteria": null, "exerciseCriteria": null, "mailCriteria": null, "affectedExercise": null, "affectedPage": null, "affectedDialogResponse": "chapter4/2.4.4.1.1.2/dialogResponse1.json", "affectedMail": null } ] }

I think "affectedDialogResponse" should be "chapter4/2.4.5.1.1.2/dialogResponse1.json"
If this is the case, I don't think it is a bug.

@martindusinberre
Copy link
Collaborator Author

Great, good spot, Lena. I've corrected the pageTransition1.json for 2.4.5.1.1.2. Could you test it again? I've created a temporary shortcut to 2.4.5.1.1.1 to speed things up... If it seems solved, then please close the issue.

@yaslena
Copy link
Collaborator

yaslena commented Oct 13, 2019

It works now.

@yaslena yaslena closed this as completed Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high high priority
Projects
None yet
Development

No branches or pull requests

4 participants