Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imageComponent files with multiple jpg images #7

Closed
martindusinberre opened this issue Aug 12, 2019 · 12 comments
Closed

imageComponent files with multiple jpg images #7

martindusinberre opened this issue Aug 12, 2019 · 12 comments
Assignees
Labels
bug Something isn't working high high priority

Comments

@martindusinberre
Copy link
Collaborator

This remains a problem (as of Monday 5th August), although my comment on Rocketchat was on July 22nd: Last week, when I played, I came into 2.4.3.2 from 2.4.3.1.1.5, and instead of showing the correct image at 2.4.3.2, the game gave me an image from 2.4.3.1.1.5 which stayed with me for the rest of my game play to the end of ch4.
Similarly, today, I came into 2.4.3.2 from 2.4.3.1.5.4 (HPV) and for the rest of the game (end of ch4) I had the 2.4.3.1.5.4 image.

@christian-bernet christian-bernet self-assigned this Aug 13, 2019
@christian-bernet
Copy link
Contributor

works on my local machine. Recheck it at the testsystem.

@christian-bernet christian-bernet removed their assignment Aug 14, 2019
@martindusinberre
Copy link
Collaborator Author

This is still a problem. I'm on 2.4.1.3.1.5 but the imageComponent is still the multiple jpg files from 2.4.1.3.1.4.
Even when I transition to 2.4.2.1, the image from 2.4.1.3.1.4 is still showing

@christian-bernet
Copy link
Contributor

On 2.4.3.1.1.5 to 2.4.3.2 I can not reproduce this error.
Let us check that together.

@christian-bernet christian-bernet removed their assignment Aug 14, 2019
@martindusinberre
Copy link
Collaborator Author

I've worked out in more detail what happens: this problem only occurs if, while on 2.4.1.3.1.3, the player actually opens the zoom function. (The problem doesn't occur if the player doesn't open any of the imageComponents using the zoom function.)
If I scroll forward to, say, image 5/7 in the zoomed image on 2.4.1.3.1.3, then the imageComponent on 2.4.1.3.1.4 will now start at image 5 (out of 6).
And then, when I transition into 2.4.1.3.1.5, where an entirely different imageComponent should be displayed, then the imageComponent remains at image 5 out of 6 from 2.4.1.3.1.4.
And when I continue to 2.4.2.1, the imageComponent remains image 5 out of 6 from 2.4.1.3.1.4
Like the split-screen bug, the workaround is to refresh the URL.
Will this allow you to reproduce the error?

@martindusinberre martindusinberre changed the title imageComponent files with multiple jpg images imageComponent files with multiple jpg images [high] Aug 14, 2019
@christian-bernet
Copy link
Contributor

christian-bernet commented Aug 15, 2019

perfect. That will help. So we can fix that.
@zlaxi last comment from martin is for you.

@interrogator interrogator added the high high priority label Aug 15, 2019
@interrogator interrogator changed the title imageComponent files with multiple jpg images [high] imageComponent files with multiple jpg images Aug 15, 2019
@christian-bernet christian-bernet added the bug Something isn't working label Aug 20, 2019
@christian-bernet
Copy link
Contributor

Estimate 2 hours

@christian-bernet
Copy link
Contributor

christian-bernet commented Sep 12, 2019

in the newest version if I zoom the image it is not centered anymore.
image

@zlaxi zlaxi assigned christian-bernet and unassigned zlaxi Sep 13, 2019
@zlaxi
Copy link

zlaxi commented Sep 13, 2019

uzh/marugoto-frontend@7b76031

Order number fixed on component transition, and zoom algorithm adjusted

@christian-bernet
Copy link
Contributor

christian-bernet commented Sep 16, 2019

not done yet.... And also there are some warnings, when building the frontend

@christian-bernet christian-bernet assigned zlaxi and unassigned zlaxi Sep 16, 2019
@christian-bernet
Copy link
Contributor

ok. that is done now and also on test-system.
Please recheck it.

@martindusinberre martindusinberre removed their assignment Sep 19, 2019
@martindusinberre
Copy link
Collaborator Author

@lfeine @Helena-LiT Please check this, but I think it is fixed. If you're happy, please close the issue on Friday.

@yaslena
Copy link
Collaborator

yaslena commented Sep 21, 2019

I think it is fixed, no lingering images any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high high priority
Projects
None yet
Development

No branches or pull requests

6 participants